rsync - Oct 2013 - Cannot build rsync 3.1.0 on MacOSX 10.8.5 with fileflags patch

Returning to this list after a long hiatus: rsync 3 has been working very well
for me for many years, as a supplementary backup tool for MacOSX.

However, attempting to build the new 3.1.0 release on a brand new Mountain Lion
box with my standard 'fileflags' and 'crimes' patches applied,
make fails, reporting that 'force_change' is undeclared.

In fact, the problem occurs just with the 'fileflags' patch alone:

	patch -p1 <patches/fileflags.diff
	./configure
	make

This generates the error:

gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -I./zlib  -c main.c -o
main.o
main.c:846:6: error: use of undeclared identifier 'force_change'
        if (force_change & SYS_IMMUTABLE) {
            ^
1 error generated.
make: *** [main.o] Error 1

Building without the fileflags patch is successful.

Has anyone else noticed this behaviour?

Regards,
Tony Morton

> However, attempting to build the new 3.1.0 release on a brand new Mountain
Lion box with my standard 'fileflags' and 'crtimes' patches
applied, make fails, reporting that 'force_change' is undeclared.
Scott Lasley suggested a workaround for this: apply the
'hfs-compression' patch in addition to 'fileflags' and
'crimes' and everything works.

	patch -p1 <patches/fileflags.diff
	patch -p1 <patches/crtimes.diff
	patch -p1 <patches/hfs-compression.diff
	./prepare-source
	./configure
	make
	sudo make install

Evidently what was missing was a declaration for the force-change flag in
main.c: the latter patch adds it.

Looks like hfs-compression is a good patch to recommend for use on OS X
installations in any case.

Cheers,
Tony M.

On Thu, Oct 10, 2013 at 3:39 PM, Anthony Morton <amorton at fastmail.fm>
wrote:
> However, attempting to build the new 3.1.0 release on a brand new Mountain
> Lion box with my standard 'fileflags' and 'crimes' patches
applied, make
> fails, reporting that 'force_change' is undeclared.

Yeah, the variable declaration got stuck in the wrong patch.  I'm
checking-in a fix for that in git.  The OS X patches are not well tested at
the moment.  I managed to snag an old mac to do some build testing at
least, but haven't done any testing other than making sure that it passed
the "make check" tests (which I also fixed).

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.samba.org/pipermail/rsync/attachments/20131027/0ea3ce7b/attachment.html>