rsync - Mar 2011 - [Bug 8019] New: Various improvements to the fileflags patch

https://bugzilla.samba.org/show_bug.cgi?id=8019

           Summary: Various improvements to the fileflags patch
           Product: rsync
           Version: 3.0.8
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: mike at bombich.com
         QAContact: rsync-qa at samba.org


Created attachment 6298
  --> https://bugzilla.samba.org/attachment.cgi?id=6298
Several changes to the fileflags.diff patch

The attached patch improves the following:

- The fileflags variable was occasionally referenced without being initialized
- sx.st.st_flags is initialized in flist.c:send_file_name() so get_xattr has
access to fileflags
- rsync.c: Errors that occur in undo_make_mutable are now reported (I think
this also resolves an issue in which rsync would report "Unknown error
(0)")
- rsync.c: make_mutable is now called in set_file_attrs allowing set_file_attrs
to apply acls, xattrs, times, etc. to files in locked directories.
- syscall.c: Added make_mutable/force_change functionality to many of these
system calls

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8019

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6298|0                           |1
           is patch|                            |
   Attachment #6298|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8019

--- Comment #1 from Wayne Davison <wayned at samba.org> 2011-03-19
23:02:16 UTC ---
(In reply to comment #0)
> - The fileflags variable was occasionally referenced without being
initialized
I'm not sure what you were seeing for this.  You added some setting of the
static fileflags variable to 0 for the non-fileflags option case, but that
variable is always 0 when that option is off.  I did change the bit that
initializes F_FFLAGS(file) to ensure that force_changes w/o preserve_fileflags
sets it to 0.  I also made sure that the code that fakes the value into
st_flags sets a 0 if --fileflags is off.
> [...]
> - syscall.c: Added make_mutable/force_change functionality to many of these
> system calls
I note that dirname() function expects a non-const string and may potentially
change the buffer, so it can't be used in these syscall functions.  I
created a
function that tweaks the path into a buffer and calls make_mutable() on the
result, and then twiddled your new code to make use of it.  I also enhanced
make_mutable() a bit and simplified some of the existing make_mutable() calls.

The result has been checked into the patches git repo.

Thanks!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8019

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.