samba-bugs at samba.org
2010-Sep-21 09:01 UTC
DO NOT REPLY [Bug 7691] New: rsync remove-source-files and opened file
https://bugzilla.samba.org/show_bug.cgi?id=7691
Summary: rsync remove-source-files and opened file
Product: rsync
Version: 3.0.6
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P3
Component: core
AssignedTo: wayned at samba.org
ReportedBy: thebeno at zoznam.sk
QAContact: rsync-qa at samba.org
Hi,
when I use option remove-source-files and source files is opened and growing
rsync copy partial source file and after copying remove it even though in time
after copying the files are different
I suggest to check difference after file is copying and if source and
destination are different don`t remove the source file
next improve is to setup options like remove-source-file-delay to setup some
time after copying to check difference between source and destination and
remove source only if the files are the same
next improve is to setup options like remove-source-file-loop to setup numbers
of loop to try if source file was already closed
if remove-source-file-loop=0 it will be forever
I hope this scenario could be implemented independently on OS and help many
people to use rsync for opened files.
peter
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs at samba.org
2011-Jun-18 19:32 UTC
[Bug 7691] rsync remove-source-files and opened file
https://bugzilla.samba.org/show_bug.cgi?id=7691
Wayne Davison <wayned at samba.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Version|3.0.6 |3.1.0
Resolution| |FIXED
--- Comment #1 from Wayne Davison <wayned at samba.org> 2011-06-18
19:32:24 UTC ---
While the user should not be getting themselves into this situation (if
they're
smart about it), it is good for rsync to help the user not shoot themselves in
the foot. I have made rsync re-stat the file and skip the remove if the size
or mtime is different.
This will be fixed in 3.1.0. I've also added some helpful hints in the
manpage
on how best to use --remove-source-files.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
Reasonably Related Threads
- DO NOT REPLY [Bug 7129] New: rsync 3.0.7 - unlink failed (21) - unable to delete directory
- DO NOT REPLY [Bug 5795] New: error in rsync protocol data stream (code 12) at io.c(632) [sender=3.0.4]
- [Bug 10074] New: rsync reorders --from-files alphabetically
- DO NOT REPLY [Bug 5644] New: Option to recheck basis dirs for existing dest files
- DO NOT REPLY [Bug 7109] New: Need to define NO_SYMLINK_XATTR on Linux