rsync - Jul 2008 - DO NOT REPLY [Bug 5615] New: iconv conversion not applied to symlinks

https://bugzilla.samba.org/show_bug.cgi?id=5615

           Summary: iconv conversion not applied to symlinks
           Product: rsync
           Version: 3.0.3
          Platform: Other
        OS/Version: SunOS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: nils.goroll@hamburg.de
         QAContact: rsync-qa@samba.org


Hi,

first of all: Thank you very much for the iconv feature, this is GREAT and will
help A LOT with migrations to UTF-8. Again: THANK YOU.

This bug is to report that iconv conversion rules should also be applied when
reading/creating symlinks on the sender/receiver side, respectively.

I had a brief look at the source, but I dont think i'll manage to fix it
this
week. But if help is needed on this, I might be able to find some time soon.

I'll upload a screenshot with a sample case.

Cheers, Nils


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #1 from nils.goroll@hamburg.de  2008-07-15 14:30 CST -------
Created an attachment (id=3410)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3410&action=view)
Screenshot showing symlinks not being iconv'erted


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Version|3.0.3                       |3.0.4




------- Comment #2 from wayned@samba.org  2008-08-01 21:28 CST -------
This is now fixed in the git repository and will go out in 3.0.4pre2.

I appreciate the report!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615


per_angstrom@autark.se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |per_angstrom@autark.se




------- Comment #3 from per_angstrom@autark.se  2009-03-27 08:02 CST -------
I'm having problem with symlinks and rsync (3.05/Ubuntu 9.10) with the
--iconv
option. I hope the following terminal log should make it pretty clear what my
problem is:

pang@barbaren:~$ rsync --version
rsync  version 3.0.5  protocol version 30
[..]

pang@barbaren:~$ export LC_ALL=sv_SE.utf8
pang@barbaren:~$ locale
LANG=en_US.utf8
LC_CTYPE="sv_SE.utf8"
LC_NUMERIC="sv_SE.utf8"
LC_TIME="sv_SE.utf8"
LC_COLLATE="sv_SE.utf8"
LC_MONETARY="sv_SE.utf8"
LC_MESSAGES="sv_SE.utf8"
LC_PAPER="sv_SE.utf8"
LC_NAME="sv_SE.utf8"
LC_ADDRESS="sv_SE.utf8"
LC_TELEPHONE="sv_SE.utf8"
LC_MEASUREMENT="sv_SE.utf8"
LC_IDENTIFICATION="sv_SE.utf8"
LC_ALL=sv_SE.utf8
pang@barbaren:~$ mkdir rsync-iconv-test
pang@barbaren:~$ cd rsync-iconv-test
pang@barbaren:~/rsync-iconv-test$ touch ?????????.txt
pang@barbaren:~/rsync-iconv-test$ ln -s ?????????.txt symlink
pang@barbaren:~/rsync-iconv-test$ ls -l
total 0
lrwxrwxrwx 1 pang pang 22 2009-03-27 13:23 symlink -> ?????????.txt
-rw-r--r-- 1 pang pang  0 2009-03-27 13:23 ?????????.txt

pang@barbaren:~/rsync-iconv-test$ rsync ../rsync-iconv-test /tmp/ -av --iconv
utf8,iso885915
sending incremental file list
rsync-iconv-test/
rsync-iconv-test/symlink -> ?????????.txt
rsync-iconv-test/?????????.txt

sent 192 bytes  received 42 bytes  468.00 bytes/sec
total size is 22  speedup is 0.09

pang@barbaren:~/rsync-iconv-test$ ls -l /tmp/rsync-iconv-test/
total 0
lrwxrwxrwx 1 pang pang 22 2009-03-27 13:23 symlink -> ?????????.txt
-rw-r--r-- 1 pang pang  0 2009-03-27 13:23 ?????????.txt

pang@barbaren:~/rsync-iconv-test$ export LC_ALL=sv_SE.iso885915
pang@barbaren:~/rsync-iconv-test$ locale
LANG=en_US.utf8
LC_CTYPE="sv_SE.iso885915"
LC_NUMERIC="sv_SE.iso885915"
LC_TIME="sv_SE.iso885915"
LC_COLLATE="sv_SE.iso885915"
LC_MONETARY="sv_SE.iso885915"
LC_MESSAGES="sv_SE.iso885915"
LC_PAPER="sv_SE.iso885915"
LC_NAME="sv_SE.iso885915"
LC_ADDRESS="sv_SE.iso885915"
LC_TELEPHONE="sv_SE.iso885915"
LC_MEASUREMENT="sv_SE.iso885915"
LC_IDENTIFICATION="sv_SE.iso885915"
LC_ALL=sv_SE.iso885915
pang@barbaren:~/rsync-iconv-test$ ls -l /tmp/rsync-iconv-test/
total 0
lrwxrwxrwx 1 pang pang 22 2009-03-27 13:23 symlink ->
??????????????????.txt
-rw-r--r-- 1 pang pang  0 2009-03-27 13:23 ?????????.txt

pang@barbaren:~/rsync-iconv-test$  ls -lL /tmp/rsync-iconv-test/
ls: cannot access /tmp/rsync-iconv-test/symlink: No such file or directory
total 0
l????????? ? ?    ?    ?                ? symlink
-rw-r--r-- 1 pang pang 0 2009-03-27 13:23 ?????????.txt


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #4 from per_angstrom@autark.se  2009-03-29 02:48 CST -------
Somehow I get the impression that the fix is either not in rsync 3.0.5, or it
does not work as intended.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #5 from per_angstrom@autark.se  2009-03-29 02:58 CST -------
Created an attachment (id=4033)
 --> (https://bugzilla.samba.org/attachment.cgi?id=4033&action=view)
A bash shell script to test rsync's --iconv option on symlinks

The attached shell script contains a small test program that fails consistently
for me. By default, it tests the iso8859-15 encoding but that can be modified
by setting the environment variable SECONDARY_ENCODING to another encoding
supported by iconv.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #6 from wayned@samba.org  2009-03-29 15:20 CST -------
The issue is that your're doing a local copy, and rsync isn't properly
validating that the sender supports symlink conversions when doing a local
copy.

You can work around the issue by putting the support/lsh script on your path
somewhere, adding -e lsh to your rsync command, and making one of the args use
a localhost hostname.  i.e., change the command in your test script to this:

rsync -ae lsh --iconv utf8,$SECONDARY_ENCODING \
   ./ localhost:$TMPDIR/$RSYNC_DESTINATION_DIRECTORY/

I'm checking in a fix into the git repository that makes local copies work.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #7 from per_angstrom@autark.se  2009-04-01 11:29 CST -------
Thanks for the work-around. Hoping a fixed version is available soon.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5615





------- Comment #8 from per_angstrom at autark.se  2009-09-11 02:38 CST -------
My issue seems to be fixed in rsync  version 3.0.6  protocol version 30. Tested
in Ubuntu 9.10 Alpha 5.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.