rsync - Jun 2008 - DO NOT REPLY [Bug 5528] New: rsync deletes files it shouldn't even look at!

https://bugzilla.samba.org/show_bug.cgi?id=5528

           Summary: rsync deletes files it shouldn't even look at!
           Product: rsync
           Version: 3.0.3
          Platform: Sparc
        OS/Version: Solaris
            Status: NEW
          Severity: major
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: samba@ote.taranis.org
         QAContact: rsync-qa@samba.org


Looked at the "NOTABLE CHANGES" section in 3.0.0 but i didn't see
anything that
sounded like this should work differently:

$ rm -rf /tmp/RTEST ; mkdir -p /tmp/RTEST/SRC /tmp/RTEST/TARGET/foo
$ /z/pkgs/rsync-2.6.9/bin/rsync -v -a --ignore-existing --delete
/tmp/RTEST/SRC/ /tmp/RTEST/TARGET/oink
building file list ... done
./

sent 76 bytes  received 26 bytes  204.00 bytes/sec
total size is 0  speedup is 0.00

^^^^^ As expected.

$ rm -rf /tmp/RTEST ; mkdir -p /tmp/RTEST/SRC /tmp/RTEST/TARGET/foo
$ /z/pkgs/rsync-3.0.3pre2/bin/rsync -v -a --ignore-existing --delete
/tmp/RTEST/SRC/ /tmp/RTEST/TARGET/oink
sending incremental file list
deleting foo/

sent 39 bytes  received 12 bytes  102.00 bytes/sec
total size is 0  speedup is 0.00

^^^^^ ARG!!!

Note that /tmp/RTEST/SRC/ needs to be empty and /tmp/RTEST/TARGET/oink
mustn't
exist for this to happen.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5528


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2008-06-09 09:53 CST -------
This was caused by the transfer having just a single directory in it, and the
delete-during code wasn't using the "solo-file" alternate
directory name.

The git repository now has a fix for this.  Thanks for the report!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.