rsync - Apr 2008 - DO NOT REPLY [Bug 5370] New: sockopts attempts to set options after the socket is open

https://bugzilla.samba.org/show_bug.cgi?id=5370

           Summary: sockopts attempts to set options after the socket is
                    open
           Product: rsync
           Version: 2.6.9
          Platform: x86
               URL: http://people.freebsd.org/~gordon/rsync-socket.diff
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: gordon@tetlows.org
         QAContact: rsync-qa@samba.org


rsync 2.6.9 (and from the looks of it 3.0.0) attempts to set socket options
(either via --sockopts or the rsyncd.conf socket options conf statement) after
the socket was listen()ed or connect()ed.

Specifically, I was trying to use SO_RCVBUF and SO_SNDBUF to increase my window
size and didn't get anywhere. strace confirmed that the setsockopt call
occurred after the socket was connected.

See the patch at the URL which moves the setsockopt calls into socket.c after
the sockets are created but before they are connect()ed or listen()ed


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5370





------- Comment #1 from gordon@tetlows.org  2008-04-02 17:51 CST -------
Created an attachment (id=3239)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3239&action=view)
Patch to move the setsockopt calls into socket.c

Added attachment to the bug.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5370


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #3239 is|0                           |1
           obsolete|                            |




------- Comment #2 from wayned@samba.org  2008-04-03 13:04 CST -------
Created an attachment (id=3240)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3240&action=view)
The same patch as above, but applies to 3.0.1

I updated the patch to apply to the (soon to be released) 3.0.1.  This is too
late to make it into that release, but I'll apply it soon after that.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5370


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from wayned@samba.org  2008-04-15 10:44 CST -------
I've committed this change to the git repository.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.