rsync - Mar 2008 - DO NOT REPLY [Bug 5325] New: cannot find popt.h at compile time

https://bugzilla.samba.org/show_bug.cgi?id=5325

           Summary: cannot find popt.h at compile time
           Product: rsync
           Version: 3.0.0
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: shawn.t.rutledge@gmail.com
         QAContact: rsync-qa@samba.org


When compiling I get this:

options.c:24:18: error: popt.h: No such file or directory

The fix is here:

http://lists.samba.org/archive/rsync/2007-April/017641.html

After changing it to #include "popt/popt.h", rsync builds.

I would suggest fixing the configure script to find out whether it will be
necessary to use the "system" one or the "local" one.

(apparently on the MontaVista-based system I'm working with, the library is
included but the header is not... I'm not sure why.)


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5325


shawn.t.rutledge@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor




------- Comment #1 from shawn.t.rutledge@gmail.com  2008-03-14 16:49 CST -------
Oh now I see the --with-included-popt option :-)

Anyway the configure script should be able to predict that if the header is not
found, it's not going to compile.  Maybe if either of the header or the lib
are
not found, then use the built-in version automatically.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5325


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned@samba.org  2008-03-15 01:00 CST -------
The configure script was checking for the needed library already, but did not
check if the popt.h file was in a weird place.  I made it fall-back to choosing
the included popt code if popt.h is in a popt subdir in the system (which
avoids a potential conflict between our supplied popt/popt.h and the
system's
library due to our use of -I.).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.