rsync - Mar 2008 - DO NOT REPLY [Bug 5296] New: Failed to create rounding.h!

https://bugzilla.samba.org/show_bug.cgi?id=5296

           Summary: Failed to create rounding.h!
           Product: rsync
           Version: 3.0.0
          Platform: Other
        OS/Version: FreeBSD
            Status: NEW
          Severity: blocker
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: bfriesen@simple.dallas.tx.us
         QAContact: rsync-qa@samba.org


On FreeBSD 5.4 doing a make immediately fails like this:

% gmake
Failed to create rounding.h!
gmake: *** [rounding.h] Error 1


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #1 from wayned@samba.org  2008-03-02 00:16 CST -------
I'd suggest removing the ">/dev/null 2>&1" suffix from
the CC command in the
rounding.h section of the Makefile to see what is wrong.  I'd imagine it is
some kind of a compiler failure.

I've committed a change to the Makefile.in file to show more info when
creating
rounding.h fails.  You can see that diff via gitweb:

http://git.samba.org/?p=rsync.git;a=summary

http://git.samba.org/?p=rsync.git;a=commitdiff;h=ebac03192584817d626574db28b97ef274683aa5


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296





------- Comment #2 from wayned@samba.org  2008-03-07 09:10 CST -------
Please let me know what the compiler error is you encountered.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |WORKSFORME




------- Comment #3 from wayned@samba.org  2008-03-15 02:56 CST -------
No response from reporter... closing.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296


bfriesen@simple.dallas.tx.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |




------- Comment #4 from bfriesen@simple.dallas.tx.us  2008-03-15 14:56 CST
-------
Sorry for not responding.  This is the make output once the redirection to
/dev/null is removed:

% gmake
In file included from ./rounding.c:20:
./rsync.h:390:19: iconv.h: No such file or directory
In file included from ./rsync.h:894,
                 from ./rounding.c:20:
./proto.h:266: error: syntax error before "ic"
In file included from ./rounding.c:20:
./rsync.h:390:19: iconv.h: No such file or directory
In file included from ./rsync.h:894,
                 from ./rounding.c:20:
./proto.h:266: error: syntax error before "ic"
In file included from ./rounding.c:20:
./rsync.h:390:19: iconv.h: No such file or directory
In file included from ./rsync.h:894,
                 from ./rounding.c:20:
./proto.h:266: error: syntax error before "ic"
Failed to create rounding.h!
gmake: *** [rounding.h] Error 1


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296





------- Comment #5 from bfriesen@simple.dallas.tx.us  2008-03-15 15:03 CST
-------
On my system, I have /usr/local/include/iconv.h (FreeBSD convention for non-BSD
code) and I did supply CPPFLAGS="-I/usr/local/include" to configure. 
It seems
that the bug is that the rule for rounding.h should be more like

  if $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS)

so that the user-provided CPPFLAGS is respected.

Bob


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5296


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #6 from wayned@samba.org  2008-03-15 16:11 CST -------
Thanks for figuring out what was wrong.  I've checked-in a fix for this.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.