rsync - Nov 2007 - Stop password errors from getting reported as transfer errors

On Sat, 2007-11-03 at 18:14 +0000, Wayne Davison
committed:
> Stop password errors from getting reported as transfer errors.
IMO, setting log_got_error back to zero after the password handling is a
hack.  Here are two possible better approaches:

1. Decide where the real division between setup and transfer errors is
(e.g., the beginning of client_run) and reset log_got_error there.

2. Introduce a new logcode FERROR_NO23 that is the same as FERROR except
that it doesn't cause log_got_error to be set, and use this logcode for
error messages that shouldn't cause an exit code 23.

Matt

On Sun 04 Nov 2007, Matt McCutchen wrote:
> 
> 2. Introduce a new logcode FERROR_NO23 that is the same as FERROR except
> that it doesn't cause log_got_error to be set, and use this logcode for
> error messages that shouldn't cause an exit code 23.
I'd suggest FERROR_NOT23, as the first thing I thought of when I saw
FERROR_NO23 (before reading the rest of the sentence) was "Ah, that must
return error no. 23". I.e. NO as short for number, instead of NO as in
not.


Paul Slootman