rsync - Oct 2007 - DO NOT REPLY [Bug 5050] New: rsync tries to --copy-dest in --dry-run mode

https://bugzilla.samba.org/show_bug.cgi?id=5050

           Summary: rsync tries to --copy-dest in --dry-run mode
           Product: rsync
           Version: 3.0.0
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: hashproduct+rsync@gmail.com
         QAContact: rsync-qa@samba.org


With --copy-dest, rsync tries to copy basis files with unchanged data into the
destination even in --dry-run mode; fortunately, the attempt is blocked by
do_open.  Rsync should itemize the local copy without trying to actually
perform it.

To reproduce this bug:

mkdir src dest basis
echo foo >src/file
echo foo >basis/file
rsync -r -ni --checksum --copy-dest=../basis/ src/ dest/

Result:

rsync: open "/path/to/dest/file": Success (0)
>f+++++++++ file
rsync error: some files could not be transferred (code 23) at main.c(1053)
[sender=3.0.0pre4]


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5050





------- Comment #1 from matt@mattmccutchen.net  2007-10-27 23:40 CST -------
Created an attachment (id=2955)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2955&action=view)
Fix: skip the call to copy_file in dry-run mode


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5050


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned@samba.org  2007-10-28 16:27 CST -------
Your fix is now in CVS.  Thanks!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.