rsync - Oct 2007 - non-recursive remote listing breakage in 3.0.0pre1

It would appear something snuck in that breaks non-recursive remote
listings when talking to a non-3.0.0pre1 version of rsync. The symptom
itself is simple enough to see; rather than displaying member
directories/regular files/symlinks/etc as one would expect, only
non-directories (with the exception of '.') are listed.

Other tidbits.. some obvious, some maybe not:
- not limited to just the toplevel directory within a module.
  sub-directories show the same symptom.
- local listings (rsync --list-only /pub/mirrors/slackware/) behave
  properly with 2.6.9 & 3.0.0pre1.
- listings with 2.6.9 & 3.0.0pre1 clients behave properly with 3.0.0pre1
  daemon.

For clarity, I've deliberately named the rsync binaries as
'rsync-$VERSION' for the following sample tests:

$ rsync-2.6.9 rsync://ftp.slackware.com/slackware/
drwxr-xr-x         640 2007/10/03 03:47:44 .
-rw-r--r--     5422821 2007/10/06 15:47:21 ls-lR
-rw-r--r--      716648 2007/10/06 15:47:25 ls-lR.gz
lrwxrwxrwx          14 2007/07/02 16:08:13 slackware
drwxr-xr-x         912 2007/09/12 16:27:34 slackware-10.0
drwxr-xr-x         912 2007/09/12 16:29:38 slackware-10.1
drwxr-xr-x         944 2007/09/12 16:31:34 slackware-10.2
drwxr-xr-x         496 2005/09/14 16:39:02 slackware-10.2-iso
drwxr-xr-x         984 2007/09/12 16:33:39 slackware-11.0
drwxr-xr-x         816 2006/10/02 22:14:52 slackware-11.0-iso
drwxr-xr-x         968 2007/10/02 23:32:08 slackware-12.0
drwxr-xr-x         816 2007/07/02 15:30:05 slackware-12.0-iso
drwxr-xr-x         800 1997/10/03 03:00:00 slackware-3.3
drwxr-xr-x         856 2007/09/12 16:22:24 slackware-8.1
drwxr-xr-x         888 2007/09/12 16:24:16 slackware-9.0
drwxr-xr-x         912 2007/09/12 16:25:50 slackware-9.1
drwxr-xr-x         968 2007/07/01 23:40:38 slackware-current
lrwxrwxrwx          16 2003/05/06 17:08:21 slackware_source
drwxr-xr-x         256 2007/05/30 22:07:36 unsupported

$ rsync-3.0.0pre1 rsync://ftp.slackware.com/slackware/
drwxr-xr-x         640 2007/10/03 03:47:44 .
-rw-r--r--     5422821 2007/10/06 15:47:21 ls-lR
-rw-r--r--      716648 2007/10/06 15:47:25 ls-lR.gz
lrwxrwxrwx          14 2007/07/02 16:08:13 slackware
lrwxrwxrwx          16 2003/05/06 17:08:21 slackware_source

It's safe to assume ftp.slackware.com is not using 3.0.0pre1, btw.
Production environment & all that.. :)

For the moment, that's all the info I can think of to provide. If
additional info is needed, let me know.

Erik

-- 
"Failure is not an option. (It comes bundled with Windows.)"
"If at first you don't succeed, redefine success."

On 10/6/07, Erik Jan Tromp <betageek@sympatico.ca>
wrote:
> It would appear something snuck in that breaks non-recursive remote
> listings when talking to a non-3.0.0pre1 version of rsync. The symptom
> itself is simple enough to see; rather than displaying member
> directories/regular files/symlinks/etc as one would expect, only
> non-directories (with the exception of '.') are listed.
I can reproduce this.  Pulling from an older version of rsync with
--dirs is similarly broken:

$ mkdir src src/D dest
$ rsync-2.6.9 --rsync-path=rsync-2.6.9 -ni --dirs localhost:`pwd`/src/ dest/
cd+++++++ D/
$ rsync       --rsync-path=rsync-2.6.9 -ni --dirs localhost:`pwd`/src/ dest/
[No output]

The underlying problem is that FLAG_XFER_DIR is being used
inconsistently to mean two different things: "I'm not an implied
dir"
and "delete in me".  recv_file_entry is using the "delete in
me"
meaning, and D shouldn't be deleted in because its contents were not
sent, so recv_file_entry doesn't set FLAG_XFER_DIR on D.
recv_generator wants to skip implied dirs unless unless --relative is
given without --no-implied-dirs, so it sees that D lacks FLAG_XFER_DIR
and skips it.

There's a flip side to this.  An rsync 3.0.0 sender *does* set
FLAG_XFER_DIR on dirs like D, so if deletion is enabled, the generator
incorrectly deletes all their contents!

Matt

On Sat, Oct 06, 2007 at 04:52:38PM -0400, Erik Jan Tromp
wrote:
> It would appear something snuck in that breaks non-recursive remote
> listings when talking to a non-3.0.0pre1 version of rsync.
This was a simple problem with the code that was trying to skip implied
directories failing to check if the relative flag was set.  The latest
CVS version has this fixed.  It also fixes a bug with a non-recursive
listing between two 3.0.0 rsyncs.

..wayne..