samba-bugs@samba.org
2005-Oct-22 23:22 UTC
[Bug 3202] rsync crash with long directory structure
https://bugzilla.samba.org/show_bug.cgi?id=3202 ------- Additional Comments From stano@websupport.sk 2005-10-22 16:02 ------- i find out that it crash because it fill up stack which is default 8MB, when i enlarge it to 32mb with ulimit, rsync work ok -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2005-Nov-01 17:21 UTC
[Bug 3202] rsync crash with long directory structure
https://bugzilla.samba.org/show_bug.cgi?id=3202 wayned@samba.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From wayned@samba.org 2005-11-01 10:19 ------- Your diagnostic work is helpful: rsync calls a recursive function for every level downward in the directory hierarchy, so you need enough stack to be able to descend low enough to the deepest subdir. The one thing that makes the stack memory use so large is that rsync is currently allocating a filename buffer on the stack for every level of directory descent. I'll check to see if this would be easy to optimize that. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2005-Nov-01 20:22 UTC
[Bug 3202] rsync crash with long directory structure
https://bugzilla.samba.org/show_bug.cgi?id=3202 wayned@samba.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Additional Comments From wayned@samba.org 2005-11-01 13:17 ------- The latest CVS source (also available in the latest "nightly" tar file) now uses a lot less memory for each level of directory recursion -- I eliminated the need for the MAXPATHLEN buffer, and replaced it with 3 small variables (typically 12 bytes or so). -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.