rsync - Aug 2004 - [Bug 1536] rsync aborts transferring files larger than 2 GB

https://bugzilla.samba.org/show_bug.cgi?id=1536





------- Additional Comments From wayned@samba.org  2004-07-30 13:30 -------
Created an attachment (id=589)
 --> (https://bugzilla.samba.org/attachment.cgi?id=589&action=view)
Add checks for open64 and mkstemp64 to configure

If the user's system has open64() but not mkstemp64(), we avoid using
mkstemp().

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1536


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned@samba.org  2004-07-30 13:22 -------
Turns out that HP-UX does not have a proper large-file version of mkstemp().
Your best bet for now is to undefine HAVE_SECURE_MKSTEMP in config.h and
recompile.

It would be good to add some logic into configure to do this automatically.  I
wonder if it would be sufficent to check for the functions open64() and
mkstemp64() and if the former exists but not the latter, avoid mkstemp()?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1536


4gmyikx02@sneakemail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |4gmyikx02@sneakemail.com




------- Additional Comments From 4gmyikx02@sneakemail.com  2004-08-02 14:48
-------
I tested this patch on HPUX 11.0 and it seems to work properly.  The config.log
shows that it finds open64() but not mkstemp64(), and skips mkstemp().  My only
concern would be that some OS doesn't have mkstemp64() but has a working
mkstemp().  (AIX, perhaps?)

I also tested the patched rsync with the largefiles testsuite script I recently
sent to the rsync mailing list-- it passes.

  -- Steve

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1536


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2004-08-03 10:57 -------
I checked the patch into CVS.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.