rspec users - Aug 2010 - issue with rescue_action_in_public! and testing 404 responses

Hello,


I''m new to rails and I''m trying to wrap my heads around how to
spec
controllers using RSpec (using rails 3rc1 and rspec 2.0.0.beta.19).




The problem I''ve run into is when I want to test that my controllers
respond
with a 404 for unfound records.
Whenever I run the spec, the ActiveRecord::RecordNotFound exception is not
caught by rails, causing the  spec example to fail since the exception
propagates out of the controller into the spec.


>From googling around I get that rails only handles the exceptions and does a
404 response when it''s run in production mode, and that you need to
call
rescue_action_in_public! in your example if you want this behavior for test
mode. However, this does not seem to do anything for me. The example still
fails because the exception bubbles escapes unhandled from the controller.



Do I need to set something up for the rescue_action_in_public! to work? Or
is this not the correct way to test missing records?



My full example: (using factory_girl, rspec mocks and devise)



it "respons with 404 when trying to edit non-existing reads" do
   rescue_action_in_public!
   sign_in(@user)
   Read.should_receive(:find_by_id_and_user_id!).with(2,
@user.id).and_raise(ActiveRecord::RecordNotFound)

   get :edit, :id => 2
   response.status.should eql 404
 end




and the exception:


1) ReadsController resources respons with 404 for non existing reads for GET
/reads/2/edit
    Failure/Error: get :edit, :id => 2
    ActiveRecord::RecordNotFound


Thanks,
/Christoffer
-- 
View this message in context:
http://old.nabble.com/issue-with-rescue_action_in_public%21-and-testing-404-responses-tp29382281p29382281.html
Sent from the rspec-users mailing list archive at Nabble.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/rspec-users/attachments/20100808/264a59b8/attachment-0001.html>

On Aug 8, 2010, at 2:53 PM, christofferklang wrote:
> Hello,
> I''m new to rails and I''m trying to wrap my heads around
how to spec controllers using RSpec (using rails 3rc1 and rspec 2.0.0.beta.19).
> 
> The problem I''ve run into is when I want to test that my
controllers respond with a 404 for unfound records. Whenever I run the spec, the
ActiveRecord::RecordNotFound exception is not caught by rails, causing the spec
example to fail since the exception propagates out of the controller into the
spec.
> 
> >From googling around I get that rails only handles the exceptions and
does a 404 response when it''s run in production mode, and that you need
to call rescue_action_in_public! in your example if you want this behavior for
test mode. However, this does not seem to do anything for me. The example still
fails because the exception bubbles escapes unhandled from the controller.
> 
> Do I need to set something up for the rescue_action_in_public! to work? Or
is this not the correct way to test missing records?
> 
> My full example: (using factory_girl, rspec mocks and devise)
> 
> 
> it "respons with 404 when trying to edit non-existing reads" do
>    rescue_action_in_public!
>    sign_in(@user)
>    Read.should_receive(:find_by_id_and_user_id!).with(2,
@user.id).and_raise(ActiveRecord::RecordNotFound)
> 
>    get :edit, :id => 2
>    response.status.should eql 404
>  end
> 
> 
> and the exception:
> 1) ReadsController resources respons with 404 for non existing reads for
GET /reads/2/edit
>     Failure/Error: get :edit, :id => 2
>     ActiveRecord::RecordNotFound
It''s up to you to handle the error in the controller. Something like
this in ApplicationController:

  rescue_from ActiveRecord::RecordNotFound do
    render ''/404.html'', :layout => false, :status =>
:not_found
  end

HTH,
David
> Thanks, /Christoffer 
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/rspec-users/attachments/20100809/dbda0bc3/attachment.html>

On Aug 9, 7:21?pm, David Chelimsky <dchelim... at gmail.com>
wrote:
> It''s up to you to handle the error in the controller. Something
like this in ApplicationController:
>
> ? rescue_from ActiveRecord::RecordNotFound do
> ? ? render ''/404.html'', :layout => false, :status
=> :not_found
> ? end
Actually, I believe this is a bug in Rails 3.
ActiveRecord::RecordNotFound should be handled automatically by the
ActionDispatch::ShowExceptions middleware, and then
rescue_action_in_public! in your controller test should continue to
work as it did in Rails 2, allowing you to verify the result is a 404.

I posted to rails-core about this issue:

http://groups.google.com/group/rubyonrails-core/browse_thread/thread/e7379309d2308f28