Get restful-authentication and rspec trunk from github. And a couple tests
fail. One of them is this assertion:
route_for(:controller => ''users'', :action =>
''destroy'', :id => ''1'').should
== "/users/1"
error msg is:
should route users''s ''destroy'' action correctly
The recognized options <{"action"=>"show",
"id"=>"1",
"controller"=>"users"}> did not match
<{"action"=>"destroy",
"id"=>"1",
"controller"=>"users"}>, difference:
<{"action"=>"destroy"}>
But assert_generates from rails works fine.
I myself never used route_for helper before. So I am not sure is this is the
problem of the method, or restful_authentication author misused it, or rails
2.3RC2 breaks it.
Thanks
Yi
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/rspec-users/attachments/20090308/165f6243/attachment.html>
On Sun, Mar 8, 2009 at 9:49 PM, Yi <hayafirst at gmail.com> wrote:> Get restful-authentication and rspec trunk from github. And a couple tests > fail. One of them is this assertion: > > route_for(:controller => ''users'', :action => ''destroy'', :id => ''1'').should > == "/users/1" > > error msg is: > > should route users''s ''destroy'' action correctly > > The recognized options <{"action"=>"show", "id"=>"1", > "controller"=>"users"}> did not match <{"action"=>"destroy", "id"=>"1", > "controller"=>"users"}>, difference: <{"action"=>"destroy"}> > > But? assert_generates from rails works fine. > > I myself never used route_for helper before. So I am not sure is this is the > problem of the method, or restful_authentication author misused it, or rails > 2.3RC2 breaks it.Actually, it''s rspec''s edge that breaks it, documented here: http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown Somebody should probably offer up a patch to restful_authentication. I''ll do it unless anybody else cares to volunteer. Cheers, David> > Thanks > > Yi > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >
On Sun, Mar 8, 2009 at 10:15 PM, David Chelimsky <dchelimsky at gmail.com> wrote:> On Sun, Mar 8, 2009 at 9:49 PM, Yi <hayafirst at gmail.com> wrote: >> Get restful-authentication and rspec trunk from github. And a couple tests >> fail. One of them is this assertion: >> >> route_for(:controller => ''users'', :action => ''destroy'', :id => ''1'').should >> == "/users/1" >> >> error msg is: >> >> should route users''s ''destroy'' action correctly >> >> The recognized options <{"action"=>"show", "id"=>"1", >> "controller"=>"users"}> did not match <{"action"=>"destroy", "id"=>"1", >> "controller"=>"users"}>, difference: <{"action"=>"destroy"}> >> >> But? assert_generates from rails works fine. >> >> I myself never used route_for helper before. So I am not sure is this is the >> problem of the method, or restful_authentication author misused it, or rails >> 2.3RC2 breaks it. > > Actually, it''s rspec''s edge that breaks it, documented here: > > http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown > > Somebody should probably offer up a patch to restful_authentication. > I''ll do it unless anybody else cares to volunteer.Actually, I''m already on it.> > Cheers, > David > >> >> Thanks >> >> Yi >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> >
On Sun, Mar 8, 2009 at 10:21 PM, David Chelimsky <dchelimsky at gmail.com> wrote:> On Sun, Mar 8, 2009 at 10:15 PM, David Chelimsky <dchelimsky at gmail.com> wrote: >> On Sun, Mar 8, 2009 at 9:49 PM, Yi <hayafirst at gmail.com> wrote: >>> Get restful-authentication and rspec trunk from github. And a couple tests >>> fail. One of them is this assertion: >>> >>> route_for(:controller => ''users'', :action => ''destroy'', :id => ''1'').should >>> == "/users/1" >>> >>> error msg is: >>> >>> should route users''s ''destroy'' action correctly >>> >>> The recognized options <{"action"=>"show", "id"=>"1", >>> "controller"=>"users"}> did not match <{"action"=>"destroy", "id"=>"1", >>> "controller"=>"users"}>, difference: <{"action"=>"destroy"}> >>> >>> But? assert_generates from rails works fine. >>> >>> I myself never used route_for helper before. So I am not sure is this is the >>> problem of the method, or restful_authentication author misused it, or rails >>> 2.3RC2 breaks it. >> >> Actually, it''s rspec''s edge that breaks it, documented here: >> >> http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown >> >> Somebody should probably offer up a patch to restful_authentication. >> I''ll do it unless anybody else cares to volunteer. > > Actually, I''m already on it.Here it is: http://github.com/dchelimsky/restful-authentication/commit/ad92c6cb52500c37ef81e30ac4e79adffc2f4d39 I''ve sent technoweenie a pull request. Thanks for bringing this to my attention. Cheers, David> >> >> Cheers, >> David >> >>> >>> Thanks >>> >>> Yi >>> >>> _______________________________________________ >>> rspec-users mailing list >>> rspec-users at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-users >>> >> >
David, thanks very much Yi On Sun, Mar 8, 2009 at 10:45 PM, David Chelimsky <dchelimsky at gmail.com>wrote:> On Sun, Mar 8, 2009 at 10:21 PM, David Chelimsky <dchelimsky at gmail.com> > wrote: > > On Sun, Mar 8, 2009 at 10:15 PM, David Chelimsky <dchelimsky at gmail.com> > wrote: > >> On Sun, Mar 8, 2009 at 9:49 PM, Yi <hayafirst at gmail.com> wrote: > >>> Get restful-authentication and rspec trunk from github. And a couple > tests > >>> fail. One of them is this assertion: > >>> > >>> route_for(:controller => ''users'', :action => ''destroy'', :id => > ''1'').should > >>> == "/users/1" > >>> > >>> error msg is: > >>> > >>> should route users''s ''destroy'' action correctly > >>> > >>> The recognized options <{"action"=>"show", "id"=>"1", > >>> "controller"=>"users"}> did not match <{"action"=>"destroy", "id"=>"1", > >>> "controller"=>"users"}>, difference: <{"action"=>"destroy"}> > >>> > >>> But assert_generates from rails works fine. > >>> > >>> I myself never used route_for helper before. So I am not sure is this > is the > >>> problem of the method, or restful_authentication author misused it, or > rails > >>> 2.3RC2 breaks it. > >> > >> Actually, it''s rspec''s edge that breaks it, documented here: > >> > >> http://github.com/dchelimsky/rspec-rails/blob/master/Upgrade.markdown > >> > >> Somebody should probably offer up a patch to restful_authentication. > >> I''ll do it unless anybody else cares to volunteer. > > > > Actually, I''m already on it. > > Here it is: > > > http://github.com/dchelimsky/restful-authentication/commit/ad92c6cb52500c37ef81e30ac4e79adffc2f4d39 > > I''ve sent technoweenie a pull request. > > Thanks for bringing this to my attention. > > Cheers, > David > > > > >> > >> Cheers, > >> David > >> > >>> > >>> Thanks > >>> > >>> Yi > >>> > >>> _______________________________________________ > >>> rspec-users mailing list > >>> rspec-users at rubyforge.org > >>> http://rubyforge.org/mailman/listinfo/rspec-users > >>> > >> > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/rspec-users/attachments/20090308/5f47133f/attachment.html>