thr3ads.net - rspec users - [rspec-users] Specing with Subdomains as Account Keys [Oct 2007]

If this information is useful, please help other people find it:
Share via:

Ryan Heneise

2007-Oct-26 13:35 UTC

[rspec-users] Specing with Subdomains as Account Keys

How do you go about implementing and rspecing subdomains as account  
keys? I''m sure that this must be an issues for others as well.

So I have an app using subdomains as account keys. The Application  
Controller sets up @current_company in a before filter. Everything is  
done within the context of the @current_company.

After reading about Demeter''s Revenge (http://www.lukeredpath.co.uk/ 
2007/10/18/demeters-revenge), and reading Sinclair''s advice (link  
above), I refactored @current_company.items.find(:all) to  
@current_company.find_items.

Still no luck. The spec fails with:
-- Mock ''Company'' expected :find_items with (:all) once, but
received
it 0 times

The other thing that bugs me is the size of the setup method. It''s  
getting too long and starting to smell. Obviously I must be making  
this harder on myself that it needs to be.

Any ideas?

(This question was originally posted under "Mocking/Stubbing help  
with subdomain as account key"
- http://rubyforge.org/pipermail/rspec-users/2007-October/ 
004138.html, but I''ve rephrased it to make it more clear with the  
subdomain as account key question.)


# items_controller_spec.rb
describe ItemsController, "handling GET /items" do
   fixtures :companies

   before do
     @request.host = "subdomain.test.host"
     @item = mock(Item)
     Item.stub!(:find).and_return([@item])
     @current_company = mock(Company)
     @current_company.stub!(:items).and_return([])
     @current_company.stub!(:find_items).and_return([@item])
     @current_company.stub!(:subdomain).and_return("subdomain")
   end

    # Passes
   def do_get
     get :index
   end

    # Passes
   it "should be successful" do
     do_get
     response.should be_success
   end

    # Passes
   it "should render index template" do
     do_get
     response.should render_template(''index'')
   end

   # FAILS with message:
   # Mock ''Company'' expected :find_items with (:all) once, but
received it 0 times
   it "should find all items" do
     @current_company.should_receive(:find_items).with 
(:all).and_return([@item])
     do_get
   end

   # Passes
   it "should assign the found items for the view" do
     do_get
     assigns[:items].should == [@item]
   end
end


# items_controller.rb
class ItemsController < ApplicationController
   def index
     @items = @current_company.find_items(:all)
   end
end


# company.rb
class Company < ActiveRecord::Base
   has_many :items
   def find_items(*args)
     items.find(*args)
   end
end


# application.rb
class ApplicationController < ActionController::Base
   before_filter :find_current_company
   def find_current_company
     @current_company = Company.find_by_subdomain(account_subdomain)
   end
end

sinclair bain

2007-Oct-26 17:11 UTC

head link

[rspec-users] Specing with Subdomains as Account Keys

Ryan,
Are you stubbing

@current_company = *Company.find_by_subdomain(account_subdomain)*

 in the inherited  #find_current_company method ?

Make sure the @current_company is the same one upon which you have your
expectations ?
ie

before do
 ...
 Company.stub!(:find_by_subdomain).and_return(@current_company)


end

A pint and a bag of crisps says that does it !  ; )

Cheers!
sinclair

On 10/26/07, Ryan Heneise <lists at artofmission.com>
wrote:>
> How do you go about implementing and rspecing subdomains as account
> keys? I''m sure that this must be an issues for others as well.
>
> So I have an app using subdomains as account keys. The Application
> Controller sets up @current_company in a before filter. Everything is
> done within the context of the @current_company.
>
> After reading about Demeter''s Revenge
(http://www.lukeredpath.co.uk/
> 2007/10/18/demeters-revenge), and reading Sinclair''s advice (link
> above), I refactored @current_company.items.find(:all) to
> @current_company.find_items.
>
> Still no luck. The spec fails with:
> -- Mock ''Company'' expected :find_items with (:all) once,
but received
> it 0 times
>
> The other thing that bugs me is the size of the setup method. It''s
> getting too long and starting to smell. Obviously I must be making
> this harder on myself that it needs to be.
>
> Any ideas?
>
> (This question was originally posted under "Mocking/Stubbing help
> with subdomain as account key"
> - http://rubyforge.org/pipermail/rspec-users/2007-October/
> 004138.html, but I''ve rephrased it to make it more clear with the
> subdomain as account key question.)
>
>
> # items_controller_spec.rb
> describe ItemsController, "handling GET /items" do
>    fixtures :companies
>
>    before do
>      @request.host = "subdomain.test.host"
>      @item = mock(Item)
>      Item.stub!(:find).and_return([@item])
>      @current_company = mock(Company)
>      @current_company.stub!(:items).and_return([])
>      @current_company.stub!(:find_items).and_return([@item])
>      @current_company.stub!(:subdomain).and_return("subdomain")
>    end
>
>     # Passes
>    def do_get
>      get :index
>    end
>
>     # Passes
>    it "should be successful" do
>      do_get
>      response.should be_success
>    end
>
>     # Passes
>    it "should render index template" do
>      do_get
>      response.should render_template(''index'')
>    end
>
>    # FAILS with message:
>    # Mock ''Company'' expected :find_items with (:all)
once, but
> received it 0 times
>    it "should find all items" do
>      @current_company.should_receive(:find_items).with
> (:all).and_return([@item])
>      do_get
>    end
>
>    # Passes
>    it "should assign the found items for the view" do
>      do_get
>      assigns[:items].should == [@item]
>    end
> end
>
>
> # items_controller.rb
> class ItemsController < ApplicationController
>    def index
>      @items = @current_company.find_items(:all)
>    end
> end
>
>
> # company.rb
> class Company < ActiveRecord::Base
>    has_many :items
>    def find_items(*args)
>      items.find(*args)
>    end
> end
>
>
> # application.rb
> class ApplicationController < ActionController::Base
>    before_filter :find_current_company
>    def find_current_company
>      @current_company = Company.find_by_subdomain(account_subdomain)
>    end
> end
>
>
>
> _______________________________________________
> rspec-users mailing list
> rspec-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-users
>


-- 


Cheers!
sinclair
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/rspec-users/attachments/20071026/c666062f/attachment-0001.html

Ryan Heneise

2007-Oct-26 17:27 UTC

head link

[rspec-users] Specing with Subdomains as Account Keys

On Oct 26, 2007, at 12:11 PM, sinclair bain wrote:
> Ryan,
>
> Are you stubbing
>
> @current_company = Company.find_by_subdomain(account_subdomain)
>
>  in the inherited  #find_current_company method ?
>
> Make sure the @current_company is the same one upon which you have  
> your expectations ?
> ie
>
> before do
>  ...
>  Company.stub!(:find_by_subdomain).and_return(@current_company)
>
>
> end
>
> A pint and a bag of crisps says that does it !  ; )
>
> Cheers!
> sinclair

Absolutely smashing! It worked! Here''s my setup now:

before do
   @item = mock_model(Item)
   @current_company = mock_model(Company)
   Company.stub!(:find_by_subdomain).and_return(@current_company)
   @current_company.stub!(:find_items).with("1").and_return(@item)
end

What''s your address - I''ll send you a pint and a bag of crisps
:)

Ryan







> On 10/26/07, Ryan Heneise < lists at artofmission.com> wrote:How do  
> you go about implementing and rspecing subdomains as account
> keys? I''m sure that this must be an issues for others as well.
>
> So I have an app using subdomains as account keys. The Application
> Controller sets up @current_company in a before filter. Everything is
> done within the context of the @current_company.
>
> After reading about Demeter''s Revenge
(http://www.lukeredpath.co.uk/
> 2007/10/18/demeters-revenge), and reading Sinclair''s advice (link
> above), I refactored @current_company.items.find(:all) to
> @current_company.find_items.
>
> Still no luck. The spec fails with:
> -- Mock ''Company'' expected :find_items with (:all) once,
but received
> it 0 times
>
> The other thing that bugs me is the size of the setup method. It''s
> getting too long and starting to smell. Obviously I must be making
> this harder on myself that it needs to be.
>
> Any ideas?
>
> (This question was originally posted under "Mocking/Stubbing help
> with subdomain as account key"
> - http://rubyforge.org/pipermail/rspec-users/2007-October/
> 004138.html, but I''ve rephrased it to make it more clear with the
> subdomain as account key question.)
>
>
> # items_controller_spec.rb
> describe ItemsController, "handling GET /items" do
>    fixtures :companies
>
>    before do
>      @request.host = "subdomain.test.host"
>      @item = mock(Item)
>      Item.stub!(:find).and_return([@item])
>      @current_company = mock(Company)
>      @current_company.stub!(:items).and_return([])
>      @current_company.stub!(:find_items).and_return([@item])
>      @current_company.stub!(:subdomain).and_return("subdomain")
>    end
>
>     # Passes
>    def do_get
>      get :index
>    end
>
>     # Passes
>    it "should be successful" do
>      do_get
>      response.should be_success
>    end
>
>     # Passes
>    it "should render index template" do
>      do_get
>      response.should render_template(''index'')
>    end
>
>    # FAILS with message:
>    # Mock ''Company'' expected :find_items with (:all)
once, but
> received it 0 times
>    it "should find all items" do
>      @current_company.should_receive(:find_items).with
> (:all).and_return([@item])
>      do_get
>    end
>
>    # Passes
>    it "should assign the found items for the view" do
>      do_get
>      assigns[:items].should == [@item]
>    end
> end
>
>
> # items_controller.rb
> class ItemsController < ApplicationController
>    def index
>      @items = @current_company.find_items(:all)
>    end
> end
>
>
> # company.rb
> class Company < ActiveRecord::Base
>    has_many :items
>    def find_items(*args)
>      items.find(*args)
>    end
> end
>
>
> # application.rb
> class ApplicationController < ActionController::Base
>    before_filter :find_current_company
>    def find_current_company
>      @current_company = Company.find_by_subdomain(account_subdomain)
>    end
> end
>
>
>
> _______________________________________________
> rspec-users mailing list
> rspec-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-users
>
>
>
> -- 
>
>
> Cheers!
> sinclair
> _______________________________________________
> rspec-users mailing list
> rspec-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-users

sinclair bain

2007-Oct-26 19:37 UTC

head link

[rspec-users] Specing with Subdomains as Account Keys

That''s great!

Cheers!
sinclair

On 10/26/07, Ryan Heneise <lists at artofmission.com>
wrote:>
> On Oct 26, 2007, at 12:11 PM, sinclair bain wrote:
>
> > Ryan,
> >
> > Are you stubbing
> >
> > @current_company = Company.find_by_subdomain(account_subdomain)
> >
> >  in the inherited  #find_current_company method ?
> >
> > Make sure the @current_company is the same one upon which you have
> > your expectations ?
> > ie
> >
> > before do
> >  ...
> >  Company.stub!(:find_by_subdomain).and_return(@current_company)
> >
> >
> > end
> >
> > A pint and a bag of crisps says that does it !  ; )
> >
> > Cheers!
> > sinclair
>
>
> Absolutely smashing! It worked! Here''s my setup now:
>
> before do
>    @item = mock_model(Item)
>    @current_company = mock_model(Company)
>    Company.stub!(:find_by_subdomain).and_return(@current_company)
>   
@current_company.stub!(:find_items).with("1").and_return(@item)
> end
>
> What''s your address - I''ll send you a pint and a bag of
crisps :)
>
>
> Ryan
>
>
>
>
>
>
>
>
> > On 10/26/07, Ryan Heneise < lists at artofmission.com> wrote:How
do
> > you go about implementing and rspecing subdomains as account
> > keys? I''m sure that this must be an issues for others as
well.
> >
> > So I have an app using subdomains as account keys. The Application
> > Controller sets up @current_company in a before filter. Everything is
> > done within the context of the @current_company.
> >
> > After reading about Demeter''s Revenge
(http://www.lukeredpath.co.uk/
> > 2007/10/18/demeters-revenge), and reading Sinclair''s advice
(link
> > above), I refactored @current_company.items.find(:all) to
> > @current_company.find_items.
> >
> > Still no luck. The spec fails with:
> > -- Mock ''Company'' expected :find_items with (:all)
once, but received
> > it 0 times
> >
> > The other thing that bugs me is the size of the setup method.
It''s
> > getting too long and starting to smell. Obviously I must be making
> > this harder on myself that it needs to be.
> >
> > Any ideas?
> >
> > (This question was originally posted under "Mocking/Stubbing help
> > with subdomain as account key"
> > - http://rubyforge.org/pipermail/rspec-users/2007-October/
> > 004138.html, but I''ve rephrased it to make it more clear with
the
> > subdomain as account key question.)
> >
> >
> > # items_controller_spec.rb
> > describe ItemsController, "handling GET /items" do
> >    fixtures :companies
> >
> >    before do
> >      @request.host = "subdomain.test.host"
> >      @item = mock(Item)
> >      Item.stub!(:find).and_return([@item])
> >      @current_company = mock(Company)
> >      @current_company.stub!(:items).and_return([])
> >      @current_company.stub!(:find_items).and_return([@item])
> >     
@current_company.stub!(:subdomain).and_return("subdomain")
> >    end
> >
> >     # Passes
> >    def do_get
> >      get :index
> >    end
> >
> >     # Passes
> >    it "should be successful" do
> >      do_get
> >      response.should be_success
> >    end
> >
> >     # Passes
> >    it "should render index template" do
> >      do_get
> >      response.should render_template(''index'')
> >    end
> >
> >    # FAILS with message:
> >    # Mock ''Company'' expected :find_items with (:all)
once, but
> > received it 0 times
> >    it "should find all items" do
> >      @current_company.should_receive(:find_items).with
> > (:all).and_return([@item])
> >      do_get
> >    end
> >
> >    # Passes
> >    it "should assign the found items for the view" do
> >      do_get
> >      assigns[:items].should == [@item]
> >    end
> > end
> >
> >
> > # items_controller.rb
> > class ItemsController < ApplicationController
> >    def index
> >      @items = @current_company.find_items(:all)
> >    end
> > end
> >
> >
> > # company.rb
> > class Company < ActiveRecord::Base
> >    has_many :items
> >    def find_items(*args)
> >      items.find(*args)
> >    end
> > end
> >
> >
> > # application.rb
> > class ApplicationController < ActionController::Base
> >    before_filter :find_current_company
> >    def find_current_company
> >      @current_company = Company.find_by_subdomain(account_subdomain)
> >    end
> > end
> >
> >
> >
> > _______________________________________________
> > rspec-users mailing list
> > rspec-users at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/rspec-users
> >
> >
> >
> > --
> >
> >
> > Cheers!
> > sinclair
> > _______________________________________________
> > rspec-users mailing list
> > rspec-users at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/rspec-users
>
> _______________________________________________
> rspec-users mailing list
> rspec-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/rspec-users
>


-- 


Cheers!
sinclair
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/rspec-users/attachments/20071026/1189d031/attachment.html

Possibly Parallel Threads

Search for more possibly parallel threads

rspec users - Oct 2007 - Specing with Subdomains as Account Keys

[rspec-users] Specing with Subdomains as Account Keys

[rspec-users] Specing with Subdomains as Account Keys

[rspec-users] Specing with Subdomains as Account Keys

[rspec-users] Specing with Subdomains as Account Keys

Possibly Parallel Threads