Rails spinoffs - Oct 2006 - Asynchronous AJAX Multiple onComplete bug

I encountered this bug on Safari 1.3.2 and Opera 9.02 using Prototype
1.5.0 rc1.  The problem is that when using an Ajax.Request object with
asynchronous=false, the onComplete function is called twice.

The respondToReadyState (prototype.js line 797) function was being
called multiple times for the finished request.  I added the following
code at line 798 and it fixed it.

     if (this.transport.onreadystatechange == Prototype.emptyFunction)
return;

If someone who is more familiar with XMLHttpRequests would like to look
into this and apply a patch (either the one mentioned above, or a
better one that stops the respondToReadyState from being called the
extra time) to the prototype code, that would be great.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs
-~----------~----~----~----~------~----~------~--~---

so it turns out i was hasty in posting the fix.  while it works in
safari, it breaks other browsers since the variables i used aren''t
always defined.  so you at least have to wrap it in a try....

   try {
      if (this.transport.onreadystatechange == Prototype.emptyFunction)
return;
   } catch (e) {
      this.dispatchException(e);
   }


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs
-~----------~----~----~----~------~----~------~--~---