Rails spinoffs - Sep 2006 - [PATCH] #4588 : Ajax.inPlaceEditor and special characters

Hi all,
  I submitted a diff for ticket 4588 and run the current test suite 
against it and eveyrthing works fine. I tried to generate my proper 
tests for testing special characters following the patch. However I 
don''t understand everything that needs to be done in order to properly 
insert a test in the test/unit/ajax_inplaceeditor_test.html file.

  So I modified directly the :
  <h1 id="tobeedited">To be edited</h1>
  to :
  <h1 id="tobeedited">To be edited &</h1>

  Without the patch the testInPlaceEditor failes :
31 assertions, 2 failures, 0 errors
Failure: assertEqual: expected "''To be edited
&''", actual "''To be edited
&amp;''"
Failure: assertEqual: expected "''To be edited
&''", actual "''To be edited
&amp;''"

  With the patch the testInPlaceEditor passes :
33 assertions, 0 failures, 0 errors

  I did the same tests for multiline edition.

  So if someone knowing how to implement properly the tests and/or 
explain me how to do it, hopefully this patch will get closed.

Thanks.
  Mathieu

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs
-~----------~----~----~----~------~----~------~--~---

On Sep 21, 2006, at 6:00 AM, Mathieu Jondet wrote:
>   So if someone knowing how to implement properly the tests and/or
> explain me how to do it, hopefully this patch will get closed.
Thanks, Mathieu -- I''ve taken the lead on rounding up issues for the  
inPlaceEditor, and I''ll add this to my list of issues to review.

-Clay

--
Killersoft.com




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs
-~----------~----~----~----~------~----~------~--~---

You''ll find info on testing here:
http://mir.aculo.us/articles/2006/09/16/adventures-in-javascript-testing

Best,
Thomas

Am 21.09.2006 um 15:07 schrieb Clay Loveless:
>
> On Sep 21, 2006, at 6:00 AM, Mathieu Jondet wrote:
>
>>   So if someone knowing how to implement properly the tests and/or
>> explain me how to do it, hopefully this patch will get closed.
>
> Thanks, Mathieu -- I''ve taken the lead on rounding up issues for
the
> inPlaceEditor, and I''ll add this to my list of issues to review.
>
> -Clay
>
> --
> Killersoft.com
>
>
>
>
> >
--
Thomas Fuchs
wollzelle

http://www.wollzelle.com

questentier on AIM
madrobby on irc.freenode.net

http://www.fluxiom.com :: online digital asset management
http://script.aculo.us :: Web 2.0 JavaScript
http://mir.aculo.us :: Where no web developer has gone before





--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Spinoffs" group.
To post to this group, send email to
rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-spinoffs
-~----------~----~----~----~------~----~------~--~---