Thomas Fuchs
2005-Aug-11 12:45 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Heya, I''ve just released script.aculo.us V1.5_pre1. Please give it a try! Important new stuff (since V1.1b1): * Added a main scriptaculous.js file to load in the other libraries transparently. * Fixed a condition where standard a href=xxx links wouldn''t work in autocomplete results. These do now, the onclick event is not cancelled. [thx to Jasper Slits] * Added dropOnEmpty option to Sortables to allow dropping on empty lists * Added util.js which contains various utlity functions and extensions to Prototype (note some of this might be included with the next Prototype version, so don''t rely on any stuff in util.js for now) * Allow to choose the parameter name for Ajax.Autocompleter [Cameron Braid] * Added unittest.js to distribution * Changed default revert duration for Draggables to distance- dependent algorithm [suggested by San] * Fix double unescaping in Autocompleter * Add updateElement option to Autocompleter [Rob Sharp] * Added Ajax.InPlaceEditor to controls.js [Jon Tirsen] * Fixes a bug with Droppables not recognizing a drop if no hoverclass is given [thanks drewie] * Changed Effect.Opacity to better handle 100% opacity * Added ghosting option to Draggables and Sortables * Added Element.getStyle to find computed CSS styles of an element Mostly, I''m interested in Bugs and Browser compatibility. If you patch something, be sure to grab the SVN trunk. I''m away from tomorrow until monday or tuesday, so i hope to get plenty of reports in by then. :) Thomas
Dave Strus
2005-Aug-11 13:45 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
On line 415 of dragdrop.js, I see this:
if(options.dropOnEmpty)? {
which triggers the following:
Error: missing ; before statement
Source File: XXXXXXXXXXXXXXX/dragdrop.js
Line: 415, Column: 29
Source Code:
if(options.dropOnEmpty)??{
I downloaded the .zip version.
-----Original Message-----
From: rails-spinoffs-bounces@lists.rubyonrails.org
[mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of Thomas
Fuchs
Sent: Thursday, August 11, 2005 1:28 PM
To: Ruby Spinoffs List
Subject: [Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Heya,
I''ve just released script.aculo.us V1.5_pre1.
Please give it a try!
Important new stuff (since V1.1b1):
* Added a main scriptaculous.js file to load in the other libraries
transparently.
* Fixed a condition where standard a href=xxx links wouldn''t work in
autocomplete results. These do now, the onclick event is not
cancelled. [thx to Jasper Slits]
* Added dropOnEmpty option to Sortables to allow dropping on empty lists
* Added util.js which contains various utlity functions and
extensions to Prototype (note some of this might be included with the
next Prototype version, so don''t rely on any stuff in util.js for now)
* Allow to choose the parameter name for Ajax.Autocompleter [Cameron
Braid]
* Added unittest.js to distribution
* Changed default revert duration for Draggables to distance-
dependent algorithm [suggested by San]
* Fix double unescaping in Autocompleter
* Add updateElement option to Autocompleter [Rob Sharp]
* Added Ajax.InPlaceEditor to controls.js [Jon Tirsen]
* Fixes a bug with Droppables not recognizing a drop if no hoverclass
is given [thanks drewie]
* Changed Effect.Opacity to better handle 100% opacity
* Added ghosting option to Draggables and Sortables
* Added Element.getStyle to find computed CSS styles of an element
Mostly, I''m interested in Bugs and Browser compatibility. If you
patch something, be sure to grab the SVN trunk.
I''m away from tomorrow until monday or tuesday, so i hope to get
plenty of reports in by then. :)
Thomas
_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
Dave Strus
2005-Aug-11 14:29 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
"dropOnEmpty" works great, unless the list is empty at the time Sortable.create is called. Adding if ( elements != null ) before the "for" loop on line 422 of dragdrop.js seems to fix it. -----Original Message----- From: rails-spinoffs-bounces@lists.rubyonrails.org [mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of Thomas Fuchs Sent: Thursday, August 11, 2005 1:28 PM To: Ruby Spinoffs List Subject: [Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released Heya, I''ve just released script.aculo.us V1.5_pre1. Please give it a try! Important new stuff (since V1.1b1): * Added a main scriptaculous.js file to load in the other libraries transparently. * Fixed a condition where standard a href=xxx links wouldn''t work in autocomplete results. These do now, the onclick event is not cancelled. [thx to Jasper Slits] * Added dropOnEmpty option to Sortables to allow dropping on empty lists * Added util.js which contains various utlity functions and extensions to Prototype (note some of this might be included with the next Prototype version, so don''t rely on any stuff in util.js for now) * Allow to choose the parameter name for Ajax.Autocompleter [Cameron Braid] * Added unittest.js to distribution * Changed default revert duration for Draggables to distance- dependent algorithm [suggested by San] * Fix double unescaping in Autocompleter * Add updateElement option to Autocompleter [Rob Sharp] * Added Ajax.InPlaceEditor to controls.js [Jon Tirsen] * Fixes a bug with Droppables not recognizing a drop if no hoverclass is given [thanks drewie] * Changed Effect.Opacity to better handle 100% opacity * Added ghosting option to Draggables and Sortables * Added Element.getStyle to find computed CSS styles of an element Mostly, I''m interested in Bugs and Browser compatibility. If you patch something, be sure to grab the SVN trunk. I''m away from tomorrow until monday or tuesday, so i hope to get plenty of reports in by then. :) Thomas _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
Dave Strus
2005-Aug-11 14:49 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
I''ve added these to http://wiki.script.aculo.us/scriptaculous/show/BugReports (Thanks, Jon.) -----Original Message----- From: rails-spinoffs-bounces@lists.rubyonrails.org [mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of Dave Strus Sent: Thursday, August 11, 2005 3:12 PM To: ''Thomas Fuchs''; Ruby Spinoffs List Subject: RE: [Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released "dropOnEmpty" works great, unless the list is empty at the time Sortable.create is called. Adding if ( elements != null ) before the "for" loop on line 422 of dragdrop.js seems to fix it. -----Original Message----- From: rails-spinoffs-bounces@lists.rubyonrails.org [mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of Thomas Fuchs Sent: Thursday, August 11, 2005 1:28 PM To: Ruby Spinoffs List Subject: [Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released Heya, I''ve just released script.aculo.us V1.5_pre1. Please give it a try! Important new stuff (since V1.1b1): * Added a main scriptaculous.js file to load in the other libraries transparently. * Fixed a condition where standard a href=xxx links wouldn''t work in autocomplete results. These do now, the onclick event is not cancelled. [thx to Jasper Slits] * Added dropOnEmpty option to Sortables to allow dropping on empty lists * Added util.js which contains various utlity functions and extensions to Prototype (note some of this might be included with the next Prototype version, so don''t rely on any stuff in util.js for now) * Allow to choose the parameter name for Ajax.Autocompleter [Cameron Braid] * Added unittest.js to distribution * Changed default revert duration for Draggables to distance- dependent algorithm [suggested by San] * Fix double unescaping in Autocompleter * Add updateElement option to Autocompleter [Rob Sharp] * Added Ajax.InPlaceEditor to controls.js [Jon Tirsen] * Fixes a bug with Droppables not recognizing a drop if no hoverclass is given [thanks drewie] * Changed Effect.Opacity to better handle 100% opacity * Added ghosting option to Draggables and Sortables * Added Element.getStyle to find computed CSS styles of an element Mostly, I''m interested in Bugs and Browser compatibility. If you patch something, be sure to grab the SVN trunk. I''m away from tomorrow until monday or tuesday, so i hope to get plenty of reports in by then. :) Thomas _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs _______________________________________________ Rails-spinoffs mailing list Rails-spinoffs@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
Thomas Fuchs
2005-Aug-11 14:58 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Thanks, note that i''ve just released 1.5_pre2, because the "weird character error" is a potential showstopper for many. Thanks for reporting this! Thomas Am 11.08.2005 um 22:32 schrieb Dave Strus:> I''ve added these to > http://wiki.script.aculo.us/scriptaculous/show/BugReports
Whitcraft, Jon
2005-Aug-11 15:07 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Bug in controls.js
Update line 538 to:
cancelLink.href = "javascript:void(0);";
instead of
cancelLink.href = "#";
That way if you cancel your inline edit it doesn''t jump back to the top
of the page if you are scrolled down on the page.
Jon
Already added to the BugReports Page.
-----Original Message-----
From: rails-spinoffs-bounces@lists.rubyonrails.org
[mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of
Thomas Fuchs
Sent: Thursday, August 11, 2005 3:40 PM
To: Dave Strus
Cc: Ruby Spinoffs List
Subject: Re: [Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Thanks, note that i''ve just released 1.5_pre2, because the "weird
character error" is a potential showstopper for many. Thanks for
reporting this!
Thomas
Am 11.08.2005 um 22:32 schrieb Dave Strus:
> I''ve added these to
> http://wiki.script.aculo.us/scriptaculous/show/BugReports
_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
sanzbox@yahoo.com
2005-Aug-11 15:27 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
Nice. +10 and a thanks! --- "Whitcraft, Jon" <jwhitcraft@Brickyard.com> wrote:> Bug in controls.js > > Update line 538 to: > > cancelLink.href = "javascript:void(0);"; > > instead of > > cancelLink.href = "#"; > > That way if you cancel your inline edit it doesn''t > jump back to the top > of the page if you are scrolled down on the page. > > Jon > > Already added to the BugReports Page. > > > -----Original Message----- > From: rails-spinoffs-bounces@lists.rubyonrails.org >[mailto:rails-spinoffs-bounces@lists.rubyonrails.org]> On Behalf Of > Thomas Fuchs > Sent: Thursday, August 11, 2005 3:40 PM > To: Dave Strus > Cc: Ruby Spinoffs List > Subject: Re: [Rails-spinoffs] [ANN] script.aculo.us > V1.5_pre1 released > > Thanks, note that i''ve just released 1.5_pre2, > because the "weird > character error" is a potential showstopper for > many. Thanks for > reporting this! > > Thomas > > Am 11.08.2005 um 22:32 schrieb Dave Strus: > > > I''ve added these to > > >http://wiki.script.aculo.us/scriptaculous/show/BugReports> > _______________________________________________ > Rails-spinoffs mailing list > Rails-spinoffs@lists.rubyonrails.org >http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs> _______________________________________________ > Rails-spinoffs mailing list > Rails-spinoffs@lists.rubyonrails.org >http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs>____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs
Martin Bialasinski
2005-Aug-11 18:18 UTC
[Rails-spinoffs] [ANN] script.aculo.us V1.5_pre1 released
On 11/08/05, Whitcraft, Jon <jwhitcraft@brickyard.com> wrote:> Bug in controls.js > > Update line 538 to: > > cancelLink.href = "javascript:void(0);"; > > instead of > > cancelLink.href = "#"; > > That way if you cancel your inline edit it doesn''t jump back to the top > of the page if you are scrolled down on the page.Well spotted, but I think a better fix is: --- controls.js.old 2005-08-12 01:51:36.000000000 +0200 +++ controls.js 2005-08-12 01:55:04.000000000 +0200 @@ -520,7 +520,7 @@ getForm: function() { form = document.createElement("form"); form.id = this.options.formId; - form.onsubmit = this.onSubmit.bind(this); + form.onsubmit = this.onSubmit.bindAsEventListener(this); this.createEditField(form); @@ -537,7 +537,7 @@ cancelLink = document.createElement("a"); cancelLink.href = "#"; cancelLink.appendChild(document.createTextNode(this.options.cancelText)); - cancelLink.onclick = this.onclickCancel.bind(this); + cancelLink.onclick = this.onclickCancel.bindAsEventListener(this); form.appendChild(cancelLink); return form; }, @@ -565,8 +565,9 @@ getText: function() { return this.element.innerHTML; }, - onclickCancel: function() { + onclickCancel: function(event) { this.onComplete(); + Event.stop(event); }, onFailure: function(transport) { this.options.onFailure(transport); @@ -580,7 +581,7 @@ this.oldInnerHTML = null; } }, - onSubmit: function() { + onSubmit: function(event) { this.saving = true; new Ajax.Updater( { @@ -596,7 +597,7 @@ } ); this.onLoading(); - return false; + Event.stop(event); }, onLoading: function() { this.saving = true; Bye, Martin BTW: void is an operator (just like typeof), not a function. So "void 0" is better than "void(0)"