Rails spinoffs - Jul 2005 - Small patch to Effect.Highlight

I sometimes highlight a div that originally has no background colour.

The current Effect.Highlight will leave my div with a white
background, and it was not quite right for my purposes.

My one-line-patch is simply to add the afterFinish option if there is
no current background colour (insert at line 268 of effects.js
rev:1756)

if ( !current ) options.afterFinish = function(effect){
effect.element.style.backgroundColor = ''''; };

I don''t know if there needs to be a check for an existing afterFinish
option?

-- 
Rob Wills

Have you checked out the latest trunk version on this?
http://dev.rubyonrails.org/file/spinoffs/scriptaculous/src/effects.js

It should do what you want. :)

Thomas

Am 08.07.2005 um 08:26 schrieb Rob Wills:
> I sometimes highlight a div that originally has no background colour.
>
> The current Effect.Highlight will leave my div with a white
> background, and it was not quite right for my purposes.
>
> My one-line-patch is simply to add the afterFinish option if there is
> no current background colour (insert at line 268 of effects.js
> rev:1756)
>
> if ( !current ) options.afterFinish = function(effect){
> effect.element.style.backgroundColor = ''''; };
>
> I don''t know if there needs to be a check for an existing  
> afterFinish option?
>
> -- 
> Rob Wills
> _______________________________________________
> Rails-spinoffs mailing list
> Rails-spinoffs@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
>