Rails spinoffs - Jul 2005 - Re: flashing divs in IE with use of BlindUp andBlindDown

I agree. 

-----Original Message-----
From: rails-spinoffs-bounces@lists.rubyonrails.org
[mailto:rails-spinoffs-bounces@lists.rubyonrails.org] On Behalf Of
Andrew Kaspick
Sent: Tuesday, July 12, 2005 9:40 AM
To: rails-spinoffs@lists.rubyonrails.org
Subject: Re: [Rails-spinoffs] Re: flashing divs in IE with use of
BlindUp andBlindDown

Can this "fix" proposed by Marc be integrated into the main codebase?

Again the links are...

for the original problem (IE only)....
http://sample.redlinesoftware.com/flash_test.html

and using an updated effects.js with the changes...
http://sample.redlinesoftware.com/flash_test2.html

The rendering in firefox though still looks way off compared to IE in
this case.

Thanks,
Andrew

On 6/30/05, Marc Juul Christoffersen <marcjc@gmail.com>
wrote:
> looks like this is caused by IE not liking a width or height of 0
> 
> change your BlindDown to:
> 
> Effect.BlindDown = function(element) {
>   $(element).style.height   = ''1px'';
>   $(element).style.overflow = ''hidden'';
>   Element.show(element);
>   new Effect.Scale(element, 100,
>     { scaleContent: false,
>       scaleX: false,
>       scaleMode: ''contents'',
>       scaleFrom: 0
>     }.extend(arguments[1] || {})
>   );
> }
> 
> the only change here is a start height of ''1px'' instead
of 0 also
> change the start of Effect.Scale.setDimensions from:
> 
> setDimensions: function(width, height) {
>     if(this.options.scaleX) this.element.style.width = width +
''px'';
> 
> to:
> 
> setDimensions: function(width, height) {
>     width = Math.round(width) || 1;
>     height = Math.round(height) || 1;
>     if(this.options.scaleX) this.element.style.width = width +
''px'';
> 
> That should remove the IE blinking.
> The effect still doesn''t look the same in Firefox and IE, but
I''m
> going where no computers are for the weekend so someone else will have
> to look at that.
> 
> Juul
> marcjc@gmail.com
> 
> On 6/30/05, Andrew Kaspick <akaspick@gmail.com> wrote:
> > Here''s a link showing the problem with the IE (version 6 
> > specifically) flashing issue I mentioned earlier...
> >
> > http://sample.redlinesoftware.com/flash_test.html
> 
> > On 6/24/05, Andrew Kaspick <akaspick@gmail.com> wrote:
> > > I''m having an issue with flashing divs in IE (firefox is
fine and
> > > the only other browser I''ve used)
>
_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs