Rails core - Apr 2008 - PG_Namespace cartesian join in postgresql_adapter.rb

I''m working on a patch to Rails 2.0.2 to address a cartesian join with
PG_namespace in activerecord-2.0.2/lib/active_record/
connection_adapters/postgresql_adapter.rb.  (around line 559 or so).

What I''m wondering is this:  did the original author intend to
retrieve the namespace (schema) for the database object (the sequence
that feeds the primary key, in this case), and if so, what was the
reason?  Its probably a good one, and I''d like the patch to do the
necessary in the correct fashion.  The current query doesn''t return
the schema name, so I''m thinking maybe it should, but Rails works fine
without it, since the convention (!) is to have the table and sequence
in the same schema namespace, which is in the login''s search path in
PostgreSQL.

As an old, crusty DBA/developer, I''d prefer to have a trigger populate
the surrogate primary key, but I understand this is not the One True
Rails Way, so I''m not going to fight it.  (Not here, anyway. 
I''ll
hack my own code to do what I think it needs to do.)

Any thoughts?  Please share...
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

>  I''m working on a patch to Rails 2.0.2 to address a cartesian join
with
>  PG_namespace in activerecord-2.0.2/lib/active_record/
>  connection_adapters/postgresql_adapter.rb.  (around line 559 or so).
The only thing I can remember changing in recent history is:

http://github.com/rails/rails/commit/b3b0a0c388b27ec9d658823b963f4bc59ff2f270

Is this what introduced it?  You can see the rationale in:

http://dev.rubyonrails.org/ticket/8659
-- 
Cheers

Koz

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---