David Harding
2008-Apr-23 14:11 UTC
Should patches to Rails Trac tickets be against SVN or GIT?
I noticed yesterday that a patch created against the svn repo that I had submitted in Trac does not work against the latest Git checkout. Should I grab the latest GIT and create my patch against that instead? - david --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Frederick Cheung
2008-Apr-23 14:28 UTC
Re: Should patches to Rails Trac tickets be against SVN or GIT?
On 23 Apr 2008, at 15:11, David Harding wrote:> > I noticed yesterday that a patch created against the svn repo that I > had submitted in Trac does not work against the latest Git checkout. > Should I grab the latest GIT and create my patch against that instead?Yup. svn isn''t going anywhere. Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
David Harding
2008-Apr-23 14:44 UTC
Re: Should patches to Rails Trac tickets be against SVN or GIT?
On Apr 23, 10:28 am, Frederick Cheung <frederick.che...@gmail.com> wrote:> > I noticed yesterday that a patch created against the svn repo that I > > had submitted in Trac does not work against the latest Git checkout. > > Should I grab the latest GIT and create my patch against that instead? > > Yup. svn isn''t going anywhere.http://dev.rubyonrails.org still says to create patches using svn. Are there instructions somewhere on how you would like patches to be made against the git repo? - david --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Frederick Cheung
2008-Apr-23 15:01 UTC
Re: Should patches to Rails Trac tickets be against SVN or GIT?
On 23 Apr 2008, at 15:44, David Harding wrote:> > On Apr 23, 10:28 am, Frederick Cheung <frederick.che...@gmail.com> > wrote: > >>> I noticed yesterday that a patch created against the svn repo that I >>> had submitted in Trac does not work against the latest Git checkout. >>> Should I grab the latest GIT and create my patch against that >>> instead? >> >> Yup. svn isn''t going anywhere. > > http://dev.rubyonrails.org still says to create patches using svn. Are > there instructions somewhere on how you would like patches to be made > against the git repo? >trac is also deprecated :-) http://rails.lighthouseapp.com/ see also http://www.tpope.net/rails-git-best-practices Fred> - david > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Stephen Celis
2008-Apr-23 16:56 UTC
Re: Should patches to Rails Trac tickets be against SVN or GIT?
Shouldn''t the wiki get updated? Stephen On Apr 23, 10:01 am, Frederick Cheung <frederick.che...@gmail.com> wrote:> On 23 Apr 2008, at 15:44, David Harding wrote: > > > > > On Apr 23, 10:28 am, Frederick Cheung <frederick.che...@gmail.com> > > wrote: > > >>> I noticed yesterday that a patch created against the svn repo that I > >>> had submitted in Trac does not work against the latest Git checkout. > >>> Should I grab the latest GIT and create my patch against that > >>> instead? > > >> Yup. svn isn''t going anywhere. > > >http://dev.rubyonrails.orgstill says to create patches using svn. Are > > there instructions somewhere on how you would like patches to be made > > against the git repo? > > trac is also deprecated :-)http://rails.lighthouseapp.com/ > see alsohttp://www.tpope.net/rails-git-best-practices > > Fred > > > - david--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Michael Koziarski
2008-Apr-23 21:29 UTC
Re: Should patches to Rails Trac tickets be against SVN or GIT?
On Thu, Apr 24, 2008 at 4:56 AM, Stephen Celis <stephen.celis@gmail.com> wrote:> > Shouldn''t the wiki get updated?Yes, definitely. I''ll try to get something done over the next day or so. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---