Rails core - Apr 2008 - [PATCH] better mailer generator, tests (needs review)

Hello there,

The model generated by mailer generator isn''t exactly nice.
I''ve created a patch to fix this:
http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/20-improve-mailer-generator-and-add-tests

Three commits (patchfiles) for 3 things:

   1. major generator tests cleanup and adding of mailer generator test
   2. nicer generated model
   3. added "default_url_options[:host]"

What do you think of the resulting model? Need feedback on this.
Thanks,

- Mislav

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Nevermind this, people. Josh Peek accepted and commited even before I
finished this email (but I haven't seen it then). Thanks, Josh.

On Sat, Apr 19, 2008 at 12:19 AM, Mislav Marohnić
<mislav.marohnic@gmail.com>
wrote:
> Hello there,
>
> The model generated by mailer generator isn't exactly nice.
> I've created a patch to fix this:
>
>
http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/20-improve-mailer-generator-and-add-tests
>
> Three commits (patchfiles) for 3 things:
>
>    1. major generator tests cleanup and adding of mailer generator test
>    2. nicer generated model
>    3. added "default_url_options[:host]"
>
> What do you think of the resulting model? Need feedback on this.
> Thanks,
>
> - Mislav
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---