In my frozen 1.2.3 app, the TestSession source code contains this:
def [](key)
data[key.to_s]
end
def []=(key, value)
data[key.to_s] = value
end
but in my newly-frozen 2.02 app, the TestSesison source contains this:
def [](key)
data[key]
end
def []=(key, value)
data[key] = value
end
I found this when attempting to track down why one of my tests was
failing after upgrading to 2.0.2. My application stores session data
using a symbol, but the test code was testing it by using a string.
This worked under 1.2.3 but the test now fails under 2.0.2.
Should I fix my test because this is desired new behavior? Or submit
a patch instead?
Thanks!
Jeff
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
> Should I fix my test because this is desired new behavior? Or submit > a patch instead?This doesn''t sound like a deliberate change. Please send a patch with failing tests and we''ll get it applied. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 15, 9:56 pm, "Michael Koziarski" <mich...@koziarski.com> wrote:> > Should I fix my test because this is desired new behavior? Or submit > > a patch instead? > > This doesn''t sound like a deliberate change. Please send a patch with > failing tests and we''ll get it applied. > > -- > Cheers > > KozThanks for the reply. I''ll try to tackle that by the end of this week. Jeff --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 15, 7:56 pm, "Michael Koziarski" <mich...@koziarski.com> wrote:> This doesn''t sound like a deliberate change. Please send a patch with > failing tests and we''ll get it applied.It was changed to be indifferent in [6086], but rolled back in [6145] because the change broke some functional test stuff in 1.2.2. There''s already a ticket going at #7372 (http://dev.rubyonrails.org/ ticket/7372) with a patch up for discussion. Chris --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 17, 10:52 am, Chris Kampmeier <ChrisGKampme...@gmail.com> wrote:> On Jan 15, 7:56 pm, "Michael Koziarski" <mich...@koziarski.com> wrote: > There''s already a ticket going at #7372 (http://dev.rubyonrails.org/ > ticket/7372) with a patch up for discussion. >Cool. I''ve tested the patch and gave it a +1. Jeff --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---