Rails core - Jan 2008 - Ticket #6868

Hi all,

Just adding my +1 for the 10/01/07 patch on
<http://dev.rubyonrails.org/ticket/6868> - add_column in the postgres
adapter ignoring precision and scale.

The patch is tiny and looks solid to me. The included test runs fine
with postgres and sqlite3.

Line numbers are off compared to current trunk. I''m not sure if that
matters for a one-liner + self contained test method, but could update
the patch if desired.


Regards,
Isak

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 1/14/08, Isak Hansen <isak.hansen@gmail.com>
wrote:
> Line numbers are off compared to current trunk. I''m not sure if
that
> matters for a one-liner + self contained test method, but could update
> the patch if desired.
>
Sorry, it seems I should have updated the patch for current edge.

It didn''t apply cleanly, breaking add_column in the postgresql
adapter. I''ve reopened the ticket with a patch against [8647].


Regards,
Isak

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---