Rails core - Dec 2007 - [ActiveSupport] Patches needing review: re-organization of #to_query methods, preservation of XML/JSON content-type

Just a quick pointer to some ActiveSupport patches hoping for reviews:

Puts Array#to_query and Object#to_query in the right places in
ActiveSupport - http://dev.rubyonrails.org/ticket/10395

Preserve user-specified content type for XML and JSON rendering
(currently it''s overridden and set to Mime::XML/Mimi::JSON -
http://dev.rubyonrails.org/ticket/10388

Oh and a tiny patch for inconsistency in #to_sentence:
http://dev.rubyonrails.org/ticket/10390 and a trivial doc patch for
Date.yesterday and Date.today: http://dev.rubyonrails.org/ticket/10375

Reviews appreciated! Thanks!

Cheers,
Chu Yeow

PS Rails 2.0 is almost here it seems: http://dev.rubyonrails.org/changeset/8321
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On the subject of really teenie-tinies, there''s
http://dev.rubyonrails.org/ticket/10380
The default double render error message still goes on about filters  
needing to explicitly return false, which is no longer accurate

On 7 Dec 2007, at 02:32, chuyeow wrote:
>
> Just a quick pointer to some ActiveSupport patches hoping for reviews:
>
> Puts Array#to_query and Object#to_query in the right places in
> ActiveSupport - http://dev.rubyonrails.org/ticket/10395
>
> Preserve user-specified content type for XML and JSON rendering
> (currently it''s overridden and set to Mime::XML/Mimi::JSON -
> http://dev.rubyonrails.org/ticket/10388
>
> Oh and a tiny patch for inconsistency in #to_sentence:
> http://dev.rubyonrails.org/ticket/10390 and a trivial doc patch for
> Date.yesterday and Date.today: http://dev.rubyonrails.org/ticket/10375
>
> Reviews appreciated! Thanks!
>
> Cheers,
> Chu Yeow
>
> PS Rails 2.0 is almost here it seems:
http://dev.rubyonrails.org/changeset/8321
> >

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Just a bump hoping to get some +1 love - I think my post got lost
since I posted it while the Core team was pushing out 2.0.0.



On Dec 7, 4:33 pm, Frederick Cheung <frederick.che...@gmail.com>
wrote:
> On the subject of really teenie-tinies,
there''shttp://dev.rubyonrails.org/ticket/10380
> The default double render error message still goes on about filters
> needing to explicitly return false, which is no longer accurate
>
> On 7 Dec 2007, at 02:32, chuyeow wrote:
>
>
>
> > Just a quick pointer to some ActiveSupport patches hoping for reviews:
>
> > Puts Array#to_query and Object#to_query in the right places in
> > ActiveSupport -http://dev.rubyonrails.org/ticket/10395
>
> > Preserve user-specified content type for XML and JSON rendering
> > (currently it''s overridden and set to Mime::XML/Mimi::JSON -
> >http://dev.rubyonrails.org/ticket/10388
>
> > Oh and a tiny patch for inconsistency in #to_sentence:
> >http://dev.rubyonrails.org/ticket/10390and a trivial doc patch for
> > Date.yesterday and Date.today:http://dev.rubyonrails.org/ticket/10375
>
> > Reviews appreciated! Thanks!
>
> > Cheers,
> > Chu Yeow
>
> > PS Rails 2.0 is almost here it
seems:http://dev.rubyonrails.org/changeset/8321
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---