Jim Meyer
2007-Nov-07 03:42 UTC
[PATCH] ActionController request domain/subdomains bug (Ticket 9479)
A while back I tripped over a case where ActionController flakes when handed a dotted-quad hostname behaves oddly; it (properly) asserts that the domain name is nil, but happily tells you the subdomains are the first two quads. Like so:> console >> @request = ActionController::TestRequest.new=> #<ActionController::TestRequest:0x38a2868 ...>>> @request.host = ''192.168.1.1''=> "192.168.1.1">> @request.domain=> nil>> @request.subdomains=> ["192", "168"] When patched, @request.subdomains returns an empty array. Ticket and patch (with tests): http://dev.rubyonrails.org/ticket/9479 Could I beg a quick review and, if worthy, a few +1s to get this into Rails 2? Thanks! --j --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
DHH
2007-Nov-07 14:58 UTC
Re: ActionController request domain/subdomains bug (Ticket 9479)
> Could I beg a quick review and, if worthy, a few +1s to get this into > Rails 2?Good stuff. Applied. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---