moronatural@gmail.com
2007-Nov-06 07:37 UTC
[PATCH] ActionController::CgiRequest#host_with_port() should handle standard port
Hi everyone, I''m looking for some +1''s for a bug fix patch I submitted: http://dev.rubyonrails.org/ticket/10082 The problem is that CgiRequest#host_with_port() overrides AbstractRequest#host_with_port() and does''nt use port_string() with standard_port() care. So I created patch to rename CgiRequest#host_with_port() to host_with_port_without_standard_port_handling(). And then CgiRequest#host_with_port() is inherited AbstractRequest''s one, which cares standard_port handling. Thank, -- MOROHASHI Kyosuke (moronatural@gmail.com) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
DHH
2007-Nov-06 16:36 UTC
Re: ActionController::CgiRequest#host_with_port() should handle standard port
> I''m looking for some +1''s for a bug fix patch I submitted:http://dev.rubyonrails.org/ticket/10082Looked good. Applied. Thanks! --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---