Rails core - Oct 2007 - New patch for 9834 (bug in RAILS_GEM_VERSION parsing)

Hi,

I''ve made a new patch for 9834. It''s a cleaner version of
Alex''s patch:

* Still fixes original bug
* Handles double-quoted version as well as single-quoted
* made against latest trunk as of this comment
* includes both the file and test diffs, in the correct location
relative to source root
* has cleaner and more detailed tests

Let me know if this has any problems, I can clean it up.

Thanks,
-- Chad

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 10/18/07, Chad Woolley <thewoolleyman@gmail.com>
wrote:
> I''ve made a new patch for 9834. It''s a cleaner version of
Alex''s patch:
>
> * Still fixes original bug
> * Handles double-quoted version as well as single-quoted
> * made against latest trunk as of this comment
> * includes both the file and test diffs, in the correct location
> relative to source root
> * has cleaner and more detailed tests
>
> Let me know if this has any problems, I can clean it up.
Hey Chad, nice! I merged [7832] from 1-2-stable to trunk which will
affect your patch.

jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 10/18/07, Jeremy Kemper <jeremy@bitsweat.net>
wrote:
>
> Hey Chad, nice! I merged [7832] from 1-2-stable to trunk which will
> affect your patch.
Thanks.  I''ll take a look and try to get an updated patch.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

OK, an updated patch is attached to the bug.

Thanks!
-- Chad

On 10/18/07, Jeremy Kemper <jeremy@bitsweat.net>
wrote:
>
> On 10/18/07, Chad Woolley <thewoolleyman@gmail.com> wrote:
> > I''ve made a new patch for 9834. It''s a cleaner
version of Alex''s patch:
> >
> > * Still fixes original bug
> > * Handles double-quoted version as well as single-quoted
> > * made against latest trunk as of this comment
> > * includes both the file and test diffs, in the correct location
> > relative to source root
> > * has cleaner and more detailed tests
> >
> > Let me know if this has any problems, I can clean it up.
>
> Hey Chad, nice! I merged [7832] from 1-2-stable to trunk which will
> affect your patch.
>
> jeremy
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---