Rails core - Oct 2007 - Patch review requested: 4 date/time-related patches

Looking for patch reviews for these four date/time-related patches:

1. defect: Time #years_since/ago give different results from #advance
and #plus/minus_with_duration when advancing from leap day
http://dev.rubyonrails.org/ticket/9865

2. defect: Date #years_since/ago raises Invalid Date error with leap
day
http://dev.rubyonrails.org/ticket/9864

3. refactor: Time and Date #months_since/ago uses #advance instead of
custom logic
http://dev.rubyonrails.org/ticket/9863

4. enhancement: Time and DateTime #advance honors :hours, :minutes
and :seconds options
http://dev.rubyonrails.org/ticket/9825

Thanks,
Geoff B


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 10/13/07, Geoff B <gbuesing@gmail.com> wrote:
> Looking for patch reviews for these four date/time-related patches:
>
> 1. defect: Time #years_since/ago give different results from #advance
> and #plus/minus_with_duration when advancing from leap day
> http://dev.rubyonrails.org/ticket/9865
>
> 2. defect: Date #years_since/ago raises Invalid Date error with leap
> day
> http://dev.rubyonrails.org/ticket/9864
>
> 3. refactor: Time and Date #months_since/ago uses #advance instead of
> custom logic
> http://dev.rubyonrails.org/ticket/9863
>
> 4. enhancement: Time and DateTime #advance honors :hours, :minutes
> and :seconds options
> http://dev.rubyonrails.org/ticket/9825
All applied. Excellent work!

Best,
jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Thanks!

One additional patch -- this one adds a :weeks option to Time, Date
and DateTime #advance:
http://dev.rubyonrails.org/ticket/9866

On Oct 13, 4:39 pm, "Jeremy Kemper" <jer...@bitsweat.net>
wrote:
> On 10/13/07, Geoff B <gbues...@gmail.com> wrote:
>
>
>
> > Looking for patch reviews for these four date/time-related patches:
>
> > 1. defect: Time #years_since/ago give different results from #advance
> > and #plus/minus_with_duration when advancing from leap day
> >http://dev.rubyonrails.org/ticket/9865
>
> > 2. defect: Date #years_since/ago raises Invalid Date error with leap
> > day
> >http://dev.rubyonrails.org/ticket/9864
>
> > 3. refactor: Time and Date #months_since/ago uses #advance instead of
> > custom logic
> >http://dev.rubyonrails.org/ticket/9863
>
> > 4. enhancement: Time and DateTime #advance honors :hours, :minutes
> > and :seconds options
> >http://dev.rubyonrails.org/ticket/9825
>
> All applied. Excellent work!
>
> Best,
> jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 10/13/07, Geoff B <gbuesing@gmail.com> wrote:
> One additional patch -- this one adds a :weeks option to Time, Date
> and DateTime #advance:
> http://dev.rubyonrails.org/ticket/9866
Got it! Thanks.

jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---