Rails core - Sep 2007 - Could someone take a look at #9477 (new fieldset_tag helper)?

Hi everyone,

I just submitted a patch for a new fieldset_tag helper.

It''s helpful and encourages developers to follow web standards, etc.

"+1"s welcome :-)

http://dev.rubyonrails.org/ticket/9477

Cheers
Damian

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

There are also no table specific tags.  I''m not sure including a new
method for a specific html tag is required.  The content_tag and tag
methods are the catch all methods for those I''d say.

Patches are welcome of course, but I don''t think this would be a
worthy addition.  I''m afraid I''d have to -1 this.

Andrew

On 9/4/07, Damian Janowski <damian.janowski@gmail.com>
wrote:
>
> Hi everyone,
>
> I just submitted a patch for a new fieldset_tag helper.
>
> It''s helpful and encourages developers to follow web standards,
etc.
>
> "+1"s welcome :-)
>
> http://dev.rubyonrails.org/ticket/9477
>
> Cheers
> Damian
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

On 9/4/07, Andrew Kaspick <akaspick@gmail.com>
wrote:
> There are also no table specific tags.  I''m not sure including a
new
> method for a specific html tag is required.  The content_tag and tag
> methods are the catch all methods for those I''d say.
I think this helper is a nice and clean wrapper for the fieldset and
legend tags, building on the "form_tag with block" beauty. It can also
encourage the use of these very important tags when it comes to
creating longer, more usable and accessible forms.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Nice work guys,  applied.

On 9/5/07, Damian Janowski <damian.janowski@gmail.com>
wrote:
>
> On 9/4/07, Andrew Kaspick <akaspick@gmail.com> wrote:
> > There are also no table specific tags.  I''m not sure
including a new
> > method for a specific html tag is required.  The content_tag and tag
> > methods are the catch all methods for those I''d say.
>
> I think this helper is a nice and clean wrapper for the fieldset and
> legend tags, building on the "form_tag with block" beauty. It can
also
> encourage the use of these very important tags when it comes to
> creating longer, more usable and accessible forms.
>
> >
>

-- 
Cheers

Koz

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

> Nice work guys,  applied.
I have updated this patch to use field_set_tag instead of
fieldset_tag, so we remain consistent with the naming from the other
helpers (text_area_tag etc).


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---