Scott Raymond
2006-Jun-27 21:41 UTC
Ticket #4888: [PATCH] EventObserver''s initialize should take third parameter, trigger.
FYI: http://dev.rubyonrails.org/ticket/4888 This patch fixes a (presumably mistaken) rollback a while ago, in Prototype''s Abstract.EventObserver.prototype.initialize method. In rev 3378, DHH changed it to allow an optional third parameter [1]. But in rev 3795, sam changed it back [2]. As a result, observe_field''s :on option [3] is ignored. So either observe_field''s documentation should be fixed, or the change should be re-applied. This patch does the latter. -Scott [1] http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_view/helpers/javascripts/prototype.js?rev=3378#L1401 [2] http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_view/helpers/javascripts/prototype.js?rev=3795#L1564 [3] http://api.rubyonrails.org/classes/ActionView/Helpers/PrototypeHelper.html#M000421