I''ve posted a couple different patches to ticket 4440, and as far as I can tell they resolve all nonstandard block syntax throughout the rails/railties module. I would be very interested in helping to move this forward, since JRuby currently requires this patch for Rails to work. What''s the next steps for this ticket? Are the patches satisfactory? -- Charles Oliver Nutter @ headius.blogspot.com JRuby Developer @ www.jruby.org Application Architect @ www.ventera.com _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
Brad Ediger
2006-Jun-27 20:41 UTC
Patching process (Was: Ticket 4440 seems mostly completed)
I think quite a few of us have been lurking on rails-core waiting for our pet patches to come through. The actual commit process seems rather opaque after a ticket is put into Trac. Would one of the core team members care to take a few minutes and explain how the process of getting a patch accepted works? Some tips on rails-core etiquette would be appreciated, also. It seems like many of us are anxious to get feedback (positive or negative) on our patches, but don''t want to seem pushy by posting to the list every time we put something in Trac. I realize you guys are busy -- thanks! -- Brad Ediger Madriska Media Group Charles O Nutter wrote:> I''ve posted a couple different patches to ticket 4440, and as far as I > can tell they resolve all nonstandard block syntax throughout the > rails/railties module. I would be very interested in helping to move > this forward, since JRuby currently requires this patch for Rails to work. > > What''s the next steps for this ticket? Are the patches satisfactory? > > -- > Charles Oliver Nutter @ headius.blogspot.com <http://headius.blogspot.com> > JRuby Developer @ www.jruby.org <http://www.jruby.org> > Application Architect @ www.ventera.com <http://www.ventera.com> > > > ------------------------------------------------------------------------ > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
Zack Chandler
2006-Jun-27 21:06 UTC
Re: Patching process (Was: Ticket 4440 seems mostly completed)
Brad, This exact question was posed to the Rails Core team at the Q and A session at RailsConf. Basically the anwser was: 1) Include documentation and describe WHY this needs to be done. 2) Include tests 3) Make the patch small if possible. I think there were a few more things mentioned but that is all I can recall off the top of my head. Hope this helps, Zack On 6/27/06, Brad Ediger <brad@bradediger.com> wrote:> I think quite a few of us have been lurking on rails-core waiting for > our pet patches to come through. The actual commit process seems rather > opaque after a ticket is put into Trac. > > Would one of the core team members care to take a few minutes and > explain how the process of getting a patch accepted works? Some tips on > rails-core etiquette would be appreciated, also. It seems like many of > us are anxious to get feedback (positive or negative) on our patches, > but don''t want to seem pushy by posting to the list every time we put > something in Trac. > > I realize you guys are busy -- thanks! > > -- > Brad Ediger > Madriska Media Group > > > Charles O Nutter wrote: > > I''ve posted a couple different patches to ticket 4440, and as far as I > > can tell they resolve all nonstandard block syntax throughout the > > rails/railties module. I would be very interested in helping to move > > this forward, since JRuby currently requires this patch for Rails to work. > > > > What''s the next steps for this ticket? Are the patches satisfactory? > > > > -- > > Charles Oliver Nutter @ headius.blogspot.com <http://headius.blogspot.com> > > JRuby Developer @ www.jruby.org <http://www.jruby.org> > > Application Architect @ www.ventera.com <http://www.ventera.com> > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Rails-core mailing list > > Rails-core@lists.rubyonrails.org > > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > > >
Brad Ediger
2006-Jun-27 21:10 UTC
Re: Patching process (Was: Ticket 4440 seems mostly completed)
Well, one more reason to kick myself for not going to RailsConf! :-) Thanks, --be Zack Chandler wrote:> Brad, > This exact question was posed to the Rails Core team at the Q and A > session at RailsConf. Basically the anwser was: > > 1) Include documentation and describe WHY this needs to be done. > 2) Include tests > 3) Make the patch small if possible. > > I think there were a few more things mentioned but that is all I can > recall off the top of my head. > > Hope this helps, > > Zack > > On 6/27/06, Brad Ediger <brad@bradediger.com> wrote: >> I think quite a few of us have been lurking on rails-core waiting for >> our pet patches to come through. The actual commit process seems rather >> opaque after a ticket is put into Trac. >> >> Would one of the core team members care to take a few minutes and >> explain how the process of getting a patch accepted works? Some tips on >> rails-core etiquette would be appreciated, also. It seems like many of >> us are anxious to get feedback (positive or negative) on our patches, >> but don''t want to seem pushy by posting to the list every time we put >> something in Trac. >> >> I realize you guys are busy -- thanks! >> >> -- >> Brad Ediger >> Madriska Media Group >>_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
On 6/27/06, Charles O Nutter <headius@headius.com> wrote:> > What''s the next steps for this ticket? Are the patches satisfactory?I just tried to apply the patch in the ticket to railties svn head and several hunks failed. Perhaps we should update the patch one more time and wave our hands really fast and see if we can get someone''s attention before some more changes to railties get committed :). /Nick
I was worried about that, I had some bad patches creep into my system a while back. I''ll take the patch I have, use the same crappy program to apply it, and then get a clean one out that I know works on trunk. FYI, the 1.1.2 patch in trac should be clean, applied directly to railties dir. On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote:> > On 6/27/06, Charles O Nutter <headius@headius.com> wrote: > > > > What''s the next steps for this ticket? Are the patches satisfactory? > > I just tried to apply the patch in the ticket to railties svn head and > several hunks failed. Perhaps we should update the patch one more > time and wave our hands really fast and see if we can get someone''s > attention before some more changes to railties get committed :). > > /Nick > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core >-- Charles Oliver Nutter @ headius.blogspot.com JRuby Developer @ www.jruby.org Application Architect @ www.ventera.com _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
On 6/27/06, Charles O Nutter <headius@headius.com> wrote:> I was worried about that, I had some bad patches creep into my system a > while back. I''ll take the patch I have, use the same crappy program to apply > it, and then get a clean one out that I know works on trunk.Already done -- new patch applied. Nicholas, you have a little history with the ticket, would you be able to slip this one in? Thanks a lot! /Nick
On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote:> Already done -- new patch applied.Whoops! s/applied/attached/ :)
On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote:> > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > Already done -- new patch applied. > > Whoops! s/applied/attached/ :)s/attached/applied/ :-) _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
On 6/28/06, Nicholas Seckar <nseckar@gmail.com> wrote:> > s/attached/applied/ > :-)Thanks Nicholas!
Excellent, thank you! Does this automatically mean it will be in 1.1.4? On 6/28/06, Nicholas Seckar <nseckar@gmail.com> wrote:> > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > > Already done -- new patch applied. > > > > Whoops! s/applied/attached/ :) > > > s/attached/applied/ > > :-) > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > >-- Charles Oliver Nutter @ headius.blogspot.com JRuby Developer @ www.jruby.org Application Architect @ www.ventera.com _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
It has been applied to trunk and not stable, so no. It wouldn''t be much more work to patch stable as well if it was desired. On 6/28/06, Charles O Nutter <headius@headius.com> wrote:> > Excellent, thank you! Does this automatically mean it will be in 1.1.4? > > On 6/28/06, Nicholas Seckar <nseckar@gmail.com > wrote: > > > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > > Already done -- new patch applied. > > > > Whoops! s/applied/attached/ :) > > > s/attached/applied/ > > :-) > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > > > > > -- > Charles Oliver Nutter @ headius.blogspot.com > JRuby Developer @ www.jruby.org > Application Architect @ www.ventera.com > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > >_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
It would depend on the plans, however rough, for a 1.2 release. We''d like people to be able to use "JRuby on Rails" as soon as possible, with our plan including full "support" for Rails by the end of the summer. It would be very nice to have stable patched and eventually a 1.1.4 release with these fixes. Let me know if there''s anything I can do to help make that happen. On 6/29/06, Nicholas Seckar <nseckar@gmail.com> wrote:> > It has been applied to trunk and not stable, so no. It wouldn''t be much > more work to patch stable as well if it was desired. > > > > On 6/28/06, Charles O Nutter <headius@headius.com> wrote: > > > > Excellent, thank you! Does this automatically mean it will be in 1.1.4? > > > > On 6/28/06, Nicholas Seckar < nseckar@gmail.com > wrote: > > > > > > > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > > > On 6/27/06, Nick Sieger <nicksieger@gmail.com> wrote: > > > > > > > Already done -- new patch applied. > > > > > > Whoops! s/applied/attached/ :) > > > > > > s/attached/applied/ > > > > :-) > > > > _______________________________________________ > > Rails-core mailing list > > Rails-core@lists.rubyonrails.org > > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > > > > > > > > > > > -- > > Charles Oliver Nutter @ headius.blogspot.com > > JRuby Developer @ www.jruby.org > > Application Architect @ www.ventera.com > > > > _______________________________________________ > > Rails-core mailing list > > Rails-core@lists.rubyonrails.org > > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > > > > > > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > >-- Charles Oliver Nutter @ headius.blogspot.com JRuby Developer @ www.jruby.org Application Architect @ www.ventera.com _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core