R devel - Sep 2018 - Possible bug, max argument in print.default(), on R-3.5.1-patched

The max argument of print.default() does not override
options(max.print), see below.
R 3.5.1 and  R-devel both seem good.

G?bor
> options(max.print = 1)
> print(data.frame(a=1:10))
  a
1 1
 [ reached 'max' / getOption("max.print") -- omitted 9 rows
]
> print(data.frame(a=1:10), max  = 100)
    a
1   1
 [ reached getOption("max.print") -- omitted 9 rows
]
> options(max.print = 1000)
> R.version
               _
platform       x86_64-w64-mingw32
arch           x86_64
os             mingw32
system         x86_64, mingw32
status         Patched
major          3
minor          5.1
year           2018
month          09
day            11
svn rev        75286
language       R
version.string R version 3.5.1 Patched (2018-09-11 r75286)
nickname       Feather Spray
>

Not in print.default(), but in print.data.frame(), which is now doing its own
max= handling but not passing max to print.default (maechler, r75122 --- was
this really for r-patched?

-pd
> On 22 Sep 2018, at 23:46 , G?bor Cs?rdi <csardi.gabor at gmail.com>
wrote:
> 
> The max argument of print.default() does not override
> options(max.print), see below.
> R 3.5.1 and  R-devel both seem good.
> 
> G?bor
> 
>> options(max.print = 1)
>> print(data.frame(a=1:10))
>  a
> 1 1
> [ reached 'max' / getOption("max.print") -- omitted 9
rows ]
>> print(data.frame(a=1:10), max  = 100)
>    a
> 1   1
> [ reached getOption("max.print") -- omitted 9 rows ]
>> options(max.print = 1000)
>> R.version
>               _
> platform       x86_64-w64-mingw32
> arch           x86_64
> os             mingw32
> system         x86_64, mingw32
> status         Patched
> major          3
> minor          5.1
> year           2018
> month          09
> day            11
> svn rev        75286
> language       R
> version.string R version 3.5.1 Patched (2018-09-11 r75286)
> nickname       Feather Spray
>> 
> 
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Office: A 4.23
Email: pd.mes at cbs.dk  Priv: PDalgd at gmail.com

>>>>> peter dalgaard 
>>>>>     on Mon, 24 Sep 2018 10:16:07 +0200 writes:
    > Not in print.default(), but in print.data.frame(), which
    > is now doing its own max= handling but not passing max to
    > print.default (maechler, r75122 --- was this really for
    > r-patched?  -pd

Yes, because it solved an embarrasing thinko which lead to
enormous time spent for printing a few lines in extreme cases.

This was an incomplete bug-fix backport.. which I now have
completed (R-patched, svn rev >= 75359).

I'm sorry for the hassle.
Thank you, G?bor, for the report, and Peter for the digging!

Martin

    >> On 22 Sep 2018, at 23:46 , G?bor Cs?rdi
    >> <csardi.gabor at gmail.com> wrote:
    >> 
    >> The max argument of print.default() does not override
    >> options(max.print), see below.  R 3.5.1 and R-devel both
    >> seem good.
    >> 
    >> G?bor
    >> 
    >>> options(max.print = 1) print(data.frame(a=1:10))
    >> a 1 1 [ reached 'max' / getOption("max.print") --
omitted
    >> 9 rows ]
    >>> print(data.frame(a=1:10), max = 100)
    >> a 1 1 [ reached getOption("max.print") -- omitted 9 rows
    >> ]
    >>> options(max.print = 1000) R.version
    >> _ platform x86_64-w64-mingw32 arch x86_64 os mingw32
    >> system x86_64, mingw32 status Patched major 3 minor 5.1
    >> year 2018 month 09 day 11 svn rev 75286 language R
    >> version.string R version 3.5.1 Patched (2018-09-11
    >> r75286) nickname Feather Spray
    >>> 
    >> 
    >> ______________________________________________
    >> R-devel at r-project.org mailing list
    >> https://stat.ethz.ch/mailman/listinfo/r-devel

    > -- 
    > Peter Dalgaard, Professor, Center for Statistics,
    > Copenhagen Business School Solbjerg Plads 3, 2000
    > Frederiksberg, Denmark Phone: (+45)38153501 Office: A 4.23
    > Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com