R devel - Jun 2018 - A recent commit breaks embedded application on Windows

A line was added to call `R_SetParams ` in the function `R_SetWin32` 4 days ago.
https://github.com/wch/r-source/blob/2370eca96267e29a69396ef53a52ff5d6f60c65b/src/gnuwin32/system.c#L780
However, `R_SetParams` actually calls `R_SetWin32`.
https://github.com/wch/r-source/blob/30f7698e19fe1d2ce8fe53d85cd6cfad21fc8bb0/src/main/startup.c#L284

So it results in a stack overflow.

Related commit by Luke
https://github.com/wch/r-source/commit/2370eca96267e29a69396ef53a52ff5d6f60c65b#diff-8fa3e687488dfa88a74cb15899cf26e1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL:
<https://stat.ethz.ch/pipermail/r-devel/attachments/20180617/b9325416/attachment.sig>

Thanks for the report. Fixed in R-devel and R-patched.

Best,

luke

On Sun, 17 Jun 2018, Randy Lai wrote:
> A line was added to call `R_SetParams ` in the function `R_SetWin32` 4 days
ago.
>
https://github.com/wch/r-source/blob/2370eca96267e29a69396ef53a52ff5d6f60c65b/src/gnuwin32/system.c#L780
> However, `R_SetParams` actually calls `R_SetWin32`.
>
https://github.com/wch/r-source/blob/30f7698e19fe1d2ce8fe53d85cd6cfad21fc8bb0/src/main/startup.c#L284
>
> So it results in a stack overflow.
>
> Related commit by Luke
>
https://github.com/wch/r-source/commit/2370eca96267e29a69396ef53a52ff5d6f60c65b#diff-8fa3e687488dfa88a74cb15899cf26e1
>
>
-- 
Luke Tierney
Ralph E. Wareham Professor of Mathematical Sciences
University of Iowa                  Phone:             319-335-3386
Department of Statistics and        Fax:               319-335-3017
    Actuarial Science
241 Schaeffer Hall                  email:   luke-tierney at uiowa.edu
Iowa City, IA 52242                 WWW:  http://www.stat.uiowa.edu