Suharto Anggono Suharto Anggono
2017-Aug-19 14:35 UTC
[Rd] Issues of R_pretty in src/appl/pretty.c
Yes, they work now. I mentioned them partly because the commit description said overflow for large n and partly to be considered for regression tests. -------------------------------------------- On Sat, 19/8/17, Martin Maechler <maechler at stat.math.ethz.ch> wrote: Subject: Re: [Rd] Issues of R_pretty in src/appl/pretty.c Cc: r-devel at r-project.org Date: Saturday, 19 August, 2017, 7:47 PM>>>>> Suharto Anggono Suharto Anggono via R-devel <r-devel at r-project.org> >>>>> on Fri, 18 Aug 2017 15:44:06 +0000 writes:> Examples similar to > pretty(c(-1,1)*1e300, n = 1e9, min.n = 1) > with smaller 'n': > pretty(c(-1,1)*1e304, n = 1e5, min.n = 1) > pretty(c(-1,1)*1e306, n = 1e3, min.n = 1) Thank you. "But" all these work now (in R-devel, rev >= 73094) as they should, at least for me, right? Are you mentioning the "small n" examples so we could use them as regression tests (instead of the regression test I had added to tests/reg-large.R which needs enough GB and is slowish ) -- or are you seeing a platform where the above cases still don't work in (new enough) R-devel ? > A report on 'pretty' when working with integers, similar to what led to change of 'seq' fuzz, is https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=15137 > -------------------------------------------- > On Tue, 15/8/17, Martin Maechler <maechler at stat.math.ethz.ch> wrote: > Subject: Re: [Rd] Issues of R_pretty in src/appl/pretty.c > To: "Martin Maechler" <maechler at stat.math.ethz.ch> > @r-project.org > Date: Tuesday, 15 August, 2017, 3:55 PM [snip] > I've committed now what I think has been suggested > above ... to R-devel only : > ------------------------------------------------------------------------ > r73094 | maechler | 2017-08-15 09:10:27 +0200 (Tue, 15. Aug 2017) | 1 Zeile > Ge?nderte Pfade: > M doc/NEWS.Rd > M src/appl/pretty.c > M src/main/engine.c > M tests/reg-large.R > M tests/reg-tests-2.Rout.save > pretty(x, n) fix overflow for large n suggested by Suhartu Aggano, R-devel, 2017-08-11
>>>>> Suharto Anggono <suharto_anggono at yahoo.com> >>>>> on Sat, 19 Aug 2017 14:35:07 +0000 writes:> Yes, they work now. I mentioned them partly because the > commit description said overflow for large n and partly to > be considered for regression tests. Thank you, Suharto. I subsequently have amended NEWS and added such regression tests (in svn r73108 | 2017-08-19). Martin > -------------------------------------------- > On Sat, 19/8/17, Martin Maechler > <maechler at stat.math.ethz.ch> wrote: > Subject: Re: [Rd] Issues of R_pretty in src/appl/pretty.c > To: "Suharto Anggono Suharto Anggono" <suharto_anggono at yahoo.com> > Cc: r-devel at r-project.org > Date: Saturday, 19 August, 2017, 7:47 PM>>>>> Suharto Anggono Suharto Anggono via R-devel <r-devel at r-project.org> >>>>> on Fri, 18 Aug 2017 15:44:06 +0000 writes:>> Examples similar to >> pretty(c(-1,1)*1e300, n = 1e9, min.n = 1) >> with smaller 'n': >> pretty(c(-1,1)*1e304, n = 1e5, min.n = 1) >> pretty(c(-1,1)*1e306, n = 1e3, min.n = 1) > Thank you. > "But" all these work now (in R-devel, rev >= 73094) as they should, > at least for me, right? > Are you mentioning the "small n" examples so we could use them > as regression tests (instead of the regression test I had added > to tests/reg-large.R which needs enough GB and is slowish ) -- > or are you seeing a platform where the above cases still don't > work in (new enough) R-devel ? [...............]