Hi all, I ran into a few problems building R 3.3.1 and came up wth the attached patches (fingers crossed they don't get stripped, I've also sent this email to Jeroen since that worked last time). Would it be possible to review and merge them if they are OK? The first one uses AC_SEARCH_LIBS instead of AC_CHECK_LIB, looking for ncursesw before ncurses since ncurses is usually build with wide character support in which case non-w prefixed libraries are not created. ArchLinux (and Conda) then make fake ld linker libraries for the non-w prefixed ones. The second patch fixes a typo where CPPFLAGS is misspelt as CPPLAGS which causes them to be forgotten about in the middle of configure. Best regards, Ray. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Use-AC_SEARCH_LIBS-to-search-for-ncursesw-then-ncurs.patch Type: text/x-patch Size: 4268 bytes Desc: not available URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20160627/19522c26/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-configure-Fix-typo-CPPLAGS.patch Type: text/x-patch Size: 1197 bytes Desc: not available URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20160627/19522c26/attachment-0001.bin>
On 27/06/2016 6:58 AM, Ray Donnelly wrote:> Hi all, > > I ran into a few problems building R 3.3.1 and came up wth the > attached patches (fingers crossed they don't get stripped, I've also > sent this email to Jeroen since that worked last time). Would it be > possible to review and merge them if they are OK? > > The first one uses AC_SEARCH_LIBS instead of AC_CHECK_LIB, looking for > ncursesw before ncurses since ncurses is usually build with wide > character support in which case non-w prefixed libraries are not > created. ArchLinux (and Conda) then make fake ld linker libraries for > the non-w prefixed ones. > > The second patch fixes a typo where CPPFLAGS is misspelt as CPPLAGS > which causes them to be forgotten about in the middle of configure. > >Your patches were attached. I'll apply the second one, but I'll leave the first one for someone who knows the issues. Duncan Murdoch
On Mon, Jun 27, 2016 at 12:07 PM, Duncan Murdoch <murdoch.duncan at gmail.com> wrote:> On 27/06/2016 6:58 AM, Ray Donnelly wrote: >> >> Hi all, >> >> I ran into a few problems building R 3.3.1 and came up wth the >> attached patches (fingers crossed they don't get stripped, I've also >> sent this email to Jeroen since that worked last time). Would it be >> possible to review and merge them if they are OK? >> >> The first one uses AC_SEARCH_LIBS instead of AC_CHECK_LIB, looking for >> ncursesw before ncurses since ncurses is usually build with wide >> character support in which case non-w prefixed libraries are not >> created. ArchLinux (and Conda) then make fake ld linker libraries for >> the non-w prefixed ones. >> >> The second patch fixes a typo where CPPFLAGS is misspelt as CPPLAGS >> which causes them to be forgotten about in the middle of configure. >> >> > > Your patches were attached. I'll apply the second one, but I'll leave the > first one for someone who knows the issues.Thanks Duncan.> > Duncan Murdoch >