>>>>> Martin Maechler <maechler at stat.math.ethz.ch> >>>>> on Thu, 19 May 2016 10:26:44 +0200 writes:>>>>> <frederik at ofb.net> >>>>> on Wed, 18 May 2016 15:03:31 -0700 writes:>> Readline <= 6.2 shouldn't require the SIGWINCH patch, so >> if older versions have trouble finding rl_resize_terminal >> then you could wrap a macro around that part. > I find python related patches that use > #ifdef HAVE_RL_RESIZE_TERMINAL > so they must have configured for that. We could and > probably should do the same, but as a Linux_only guy > currently (even basically only one flavor of Linux), I'd > appreciate others to produce code for that. Actually that was easy (in hindsight.. I took too long!) enough, so I've now committed ------------------------------------------------------------------------ r70632 | maechler | 2016-05-19 10:59:51 +0200 (Thu, 19 May 2016) | 1 line Changed paths: M configure M configure.ac M src/include/config.h.in M src/unix/sys-std.c check for rl_resize_terminal() now ------------------------------------------------------------------------ ... and Keith should even not see the warning anymore (nor Peter the error, when compiling using readline 5.x instead of 6.[23]). >> The isearch C-c bug has existed forever, according to >> Chet Ramey. > I see. As your patch seems to only work for readline (>=) > 6.3, we have solved part of the problems. If those who > use olders readlines are willing to test and provide (well > looking, as yours) patches for earlier versions, they > should be welcome too. >> Yes, I had to retrain myself to use C-g to exit isearch >> but it's confusing. It would be nice to fix this C-c bug >> on older versions too, but my solution used some global >> variables and I'm not sure which Readline version they >> date from. >> Out of curiosity, did you delete the >> HAVE_READLINE_READLINE_H block? > Not yet...I've even kept your suggestion about it in the > source comments. Note you can always point your web > browser at https://svn.r-project.org/trunk/R/ which > contains upto the minute current R development sources (it > *is* our apache based subversion server), i.e., the file > in this case is > https://svn.r-project.org/trunk/R/src/unix/sys-std.c > {or you can use the github *mirror* of the svn server > which provides version/revision/log etc ((this be > available for svn as well, but we (I) had chosen not to > provide (via apache modules) just to keep our server as > bare bones as possible and hence less vulnerable to > viciousities)) }
Can you (Frederick, Peter, Keith, but ideally others, too) confirm that you don't see any problems anymore, when building a version of R-devel from sources that are newer than (or equal to) svn revision 70632 (2016-05-19 10:59:51, see below)? I'm asking because the question is open if these should be "back ported" to R 3.3.0 patched or not. Best regards, Martin>>>>> Martin Maechler <maechler at stat.math.ethz.ch> >>>>> on Thu, 19 May 2016 11:02:48 +0200 writes:>>>>> <frederik at ofb.net> >>>>> on Wed, 18 May 2016 15:03:31 -0700 writes:>>> Readline <= 6.2 shouldn't require the SIGWINCH patch, so >>> if older versions have trouble finding rl_resize_terminal >>> then you could wrap a macro around that part. >> I find python related patches that use >> #ifdef HAVE_RL_RESIZE_TERMINAL >> so they must have configured for that. We could and >> probably should do the same, but as a Linux_only guy >> currently (even basically only one flavor of Linux), I'd >> appreciate others to produce code for that. > Actually that was easy (in hindsight.. I took too long!) > enough, so I've now committed > ------------------------------------------------------------------------ > r70632 | maechler | 2016-05-19 10:59:51 +0200 (Thu, 19 May 2016) | 1 line > Changed paths: > M configure > M configure.ac > M src/include/config.h.in > M src/unix/sys-std.c > check for rl_resize_terminal() now > ------------------------------------------------------------------------ > ... and Keith should even not see the warning anymore > (nor Peter the error, when compiling using readline 5.x instead of 6.[23]). [...........]
I had a regression in config.site so the nightly build didn't. Retrying.... Looks like it will build, but the ctl-R, ctl-C bug is still present on OSX (w/Simon's libs). This _was_ fixed for a while, was it not? (The NEWS entry is also wrong: The issue existed before readline 6.3) -pd On 24 May 2016, at 12:55 , Martin Maechler <maechler at stat.math.ethz.ch> wrote:> > Can you (Frederick, Peter, Keith, but ideally others, too) > confirm that you don't see any problems anymore, when building a > version of R-devel from sources that are newer > than (or equal to) svn revision 70632 (2016-05-19 10:59:51, see below)? > > I'm asking because the question is open if these should be > "back ported" to R 3.3.0 patched or not. > > Best regards, > Martin > >>>>>> Martin Maechler <maechler at stat.math.ethz.ch> >>>>>> on Thu, 19 May 2016 11:02:48 +0200 writes: > >>>>>> <frederik at ofb.net> >>>>>> on Wed, 18 May 2016 15:03:31 -0700 writes: > >>>> Readline <= 6.2 shouldn't require the SIGWINCH patch, so >>>> if older versions have trouble finding rl_resize_terminal >>>> then you could wrap a macro around that part. > >>> I find python related patches that use > >>> #ifdef HAVE_RL_RESIZE_TERMINAL > >>> so they must have configured for that. We could and >>> probably should do the same, but as a Linux_only guy >>> currently (even basically only one flavor of Linux), I'd >>> appreciate others to produce code for that. > >> Actually that was easy (in hindsight.. I took too long!) >> enough, so I've now committed > >> ------------------------------------------------------------------------ >> r70632 | maechler | 2016-05-19 10:59:51 +0200 (Thu, 19 May 2016) | 1 line >> Changed paths: >> M configure >> M configure.ac >> M src/include/config.h.in >> M src/unix/sys-std.c > >> check for rl_resize_terminal() now >> ------------------------------------------------------------------------ > >> ... and Keith should even not see the warning anymore >> (nor Peter the error, when compiling using readline 5.x instead of 6.[23]). > > > [...........]-- Peter Dalgaard, Professor, Center for Statistics, Copenhagen Business School Solbjerg Plads 3, 2000 Frederiksberg, Denmark Phone: (+45)38153501 Office: A 4.23 Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com
On my machine (iMac w/ El Capitan (10.11.4)), svn rev. 70662 builds without any errors (and the warning I mentioned before is now gone too). K> On May 24, 2016, at 6:55 AM, Martin Maechler <maechler at stat.math.ethz.ch> wrote: > > > Can you (Frederick, Peter, Keith, but ideally others, too) > confirm that you don't see any problems anymore, when building a > version of R-devel from sources that are newer > than (or equal to) svn revision 70632 (2016-05-19 10:59:51, see below)? > > I'm asking because the question is open if these should be > "back ported" to R 3.3.0 patched or not. > > Best regards, > Martin > >>>>>> Martin Maechler <maechler at stat.math.ethz.ch> >>>>>> on Thu, 19 May 2016 11:02:48 +0200 writes: > >>>>>> <frederik at ofb.net> >>>>>> on Wed, 18 May 2016 15:03:31 -0700 writes: > >>>> Readline <= 6.2 shouldn't require the SIGWINCH patch, so >>>> if older versions have trouble finding rl_resize_terminal >>>> then you could wrap a macro around that part. > >>> I find python related patches that use > >>> #ifdef HAVE_RL_RESIZE_TERMINAL > >>> so they must have configured for that. We could and >>> probably should do the same, but as a Linux_only guy >>> currently (even basically only one flavor of Linux), I'd >>> appreciate others to produce code for that. > >> Actually that was easy (in hindsight.. I took too long!) >> enough, so I've now committed > >> ------------------------------------------------------------------------ >> r70632 | maechler | 2016-05-19 10:59:51 +0200 (Thu, 19 May 2016) | 1 line >> Changed paths: >> M configure >> M configure.ac >> M src/include/config.h.in >> M src/unix/sys-std.c > >> check for rl_resize_terminal() now >> ------------------------------------------------------------------------ > >> ... and Keith should even not see the warning anymore >> (nor Peter the error, when compiling using readline 5.x instead of 6.[23]). > > > [...........]