R devel - Apr 2016 - Under Windows, Rgui and Rterm crash if one tries to close the graphic device while identify or locator are running

If of any help,

I can reproduce this (on Windows 7) back to at least R 3.0.3 but it's
not there in R 3.0.0.  (I have *not* checked with R 3.0.1 and 3.0.2
which I don't have installed).

/Henrik


On Tue, Apr 5, 2016 at 8:23 AM, Duncan Murdoch <murdoch.duncan at
gmail.com> wrote:
> Thanks, I'll track this down.
>
> Duncan Murdoch
>
>
> On 05/04/2016 9:35 AM, Simone Giannerini wrote:
>>
>> minimal reproducible example
>>
>> plot(1,1)
>> identify(1,1) # or locator()
>>
>> now, trying to close the window by clicking on the cross of the upper
>> right corner causes Rgui (and Rterm) to crash.
>>
>> I see the same behaviour on 2 different Windows PC (one with Win 8.1
>> and one with Win 10).
>> I did not see the problem in linux (see below)
>>
>> WINDOWS **************
>> > sessionInfo()
>> R version 3.3.0 beta (2016-04-04 r70420)
>> Platform: x86_64-w64-mingw32/x64 (64-bit)
>> Running under: Windows 10 x64 (build 10586)
>>
>> locale:
>> [1] LC_COLLATE=Italian_Italy.1252  LC_CTYPE=Italian_Italy.1252
>> [3] LC_MONETARY=Italian_Italy.1252 LC_NUMERIC=C
>> [5] LC_TIME=Italian_Italy.1252
>>
>> attached base packages:
>> [1] stats     graphics  grDevices utils     datasets  methods   base
>>
>> > sessionInfo()
>> R version 3.2.2 Patched (2015-09-29 r69441)
>> Platform: x86_64-w64-mingw32/x64 (64-bit)
>> Running under: Windows 10 x64 (build 10240)
>>
>> locale:
>> [1] LC_COLLATE=Italian_Italy.1252  LC_CTYPE=Italian_Italy.1252
>> LC_MONETARY=Italian_Italy.1252
>> [4] LC_NUMERIC=C                   LC_TIME=Italian_Italy.1252
>>
>> attached base packages:
>> [1] stats     graphics  grDevices utils     datasets  methods   base
>>
>> loaded via a namespace (and not attached):
>> [1] tools_3.2.2
>>
>>
>> ** LINUX *****************************
>>
>> > sessionInfo()
>> R version 3.2.0 Patched (2015-04-21 r68221)
>> Platform: x86_64-unknown-linux-gnu (64-bit)
>> Running under: openSUSE 13.2 (Harlequin) (x86_64)
>>
>> locale:
>>   [1] LC_CTYPE=it_IT.UTF-8       LC_NUMERIC=C
>>   [3] LC_TIME=it_IT.UTF-8        LC_COLLATE=it_IT.UTF-8
>>   [5] LC_MONETARY=it_IT.UTF-8    LC_MESSAGES=it_IT.UTF-8
>>   [7] LC_PAPER=it_IT.UTF-8       LC_NAME=C
>>   [9] LC_ADDRESS=C               LC_TELEPHONE=C
>> [11] LC_MEASUREMENT=it_IT.UTF-8 LC_IDENTIFICATION=C
>>
>> attached base packages:
>> [1] stats     graphics  grDevices utils     datasets  methods   base
>>
>> --
>> ______________________________________________________
>>
>> Simone Giannerini
>> Dipartimento di Scienze Statistiche "Paolo Fortunati"
>> Universita' di Bologna
>> Via delle belle arti 41 - 40126  Bologna,  ITALY
>> Tel: +39 051 2098262  Fax: +39 051 232153
>> http://www2.stat.unibo.it/giannerini/
>>
>> ______________________________________________
>> R-devel at r-project.org mailing list
>> https://stat.ethz.ch/mailman/listinfo/r-devel
>
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

On 05/04/2016 11:56 AM, Henrik Bengtsson wrote:
> If of any help,
>
> I can reproduce this (on Windows 7) back to at least R 3.0.3 but it's
> not there in R 3.0.0.  (I have *not* checked with R 3.0.1 and 3.0.2
> which I don't have installed).
That doesn't necessarily mean that 3.0.0 was fine.  It's a segfault
(I'd
guess some memory being accessed after being freed), and it comes and 
goes as I add debugging print statements --- so it might have been there 
in 3.0.0 but we just got lucky and it never surfaced.

Still, it's a start, and I'll try bisecting between 3.0.0 and 3.0.3 to 
see if some change caused it, rather than just triggered it.

Duncan Murdoch
>
> /Henrik
>
>
> On Tue, Apr 5, 2016 at 8:23 AM, Duncan Murdoch <murdoch.duncan at
gmail.com> wrote:
> > Thanks, I'll track this down.
> >
> > Duncan Murdoch
> >
> >
> > On 05/04/2016 9:35 AM, Simone Giannerini wrote:
> >>
> >> minimal reproducible example
> >>
> >> plot(1,1)
> >> identify(1,1) # or locator()
> >>
> >> now, trying to close the window by clicking on the cross of the
upper
> >> right corner causes Rgui (and Rterm) to crash.
> >>
> >> I see the same behaviour on 2 different Windows PC (one with Win
8.1
> >> and one with Win 10).
> >> I did not see the problem in linux (see below)
> >>
> >> WINDOWS **************
> >> > sessionInfo()
> >> R version 3.3.0 beta (2016-04-04 r70420)
> >> Platform: x86_64-w64-mingw32/x64 (64-bit)
> >> Running under: Windows 10 x64 (build 10586)
> >>
> >> locale:
> >> [1] LC_COLLATE=Italian_Italy.1252  LC_CTYPE=Italian_Italy.1252
> >> [3] LC_MONETARY=Italian_Italy.1252 LC_NUMERIC=C
> >> [5] LC_TIME=Italian_Italy.1252
> >>
> >> attached base packages:
> >> [1] stats     graphics  grDevices utils     datasets  methods  
base
> >>
> >> > sessionInfo()
> >> R version 3.2.2 Patched (2015-09-29 r69441)
> >> Platform: x86_64-w64-mingw32/x64 (64-bit)
> >> Running under: Windows 10 x64 (build 10240)
> >>
> >> locale:
> >> [1] LC_COLLATE=Italian_Italy.1252  LC_CTYPE=Italian_Italy.1252
> >> LC_MONETARY=Italian_Italy.1252
> >> [4] LC_NUMERIC=C                   LC_TIME=Italian_Italy.1252
> >>
> >> attached base packages:
> >> [1] stats     graphics  grDevices utils     datasets  methods  
base
> >>
> >> loaded via a namespace (and not attached):
> >> [1] tools_3.2.2
> >>
> >>
> >> ** LINUX *****************************
> >>
> >> > sessionInfo()
> >> R version 3.2.0 Patched (2015-04-21 r68221)
> >> Platform: x86_64-unknown-linux-gnu (64-bit)
> >> Running under: openSUSE 13.2 (Harlequin) (x86_64)
> >>
> >> locale:
> >>   [1] LC_CTYPE=it_IT.UTF-8       LC_NUMERIC=C
> >>   [3] LC_TIME=it_IT.UTF-8        LC_COLLATE=it_IT.UTF-8
> >>   [5] LC_MONETARY=it_IT.UTF-8    LC_MESSAGES=it_IT.UTF-8
> >>   [7] LC_PAPER=it_IT.UTF-8       LC_NAME=C
> >>   [9] LC_ADDRESS=C               LC_TELEPHONE=C
> >> [11] LC_MEASUREMENT=it_IT.UTF-8 LC_IDENTIFICATION=C
> >>
> >> attached base packages:
> >> [1] stats     graphics  grDevices utils     datasets  methods  
base
> >>
> >> --
> >> ______________________________________________________
> >>
> >> Simone Giannerini
> >> Dipartimento di Scienze Statistiche "Paolo Fortunati"
> >> Universita' di Bologna
> >> Via delle belle arti 41 - 40126  Bologna,  ITALY
> >> Tel: +39 051 2098262  Fax: +39 051 232153
> >> http://www2.stat.unibo.it/giannerini/
> >>
> >> ______________________________________________
> >> R-devel at r-project.org mailing list
> >> https://stat.ethz.ch/mailman/listinfo/r-devel
> >
> >
> > ______________________________________________
> > R-devel at r-project.org mailing list
> > https://stat.ethz.ch/mailman/listinfo/r-devel

On 05/04/2016 3:35 PM, Duncan Murdoch wrote:
> On 05/04/2016 11:56 AM, Henrik Bengtsson wrote:
> > If of any help,
> >
> > I can reproduce this (on Windows 7) back to at least R 3.0.3 but
it's
> > not there in R 3.0.0.  (I have *not* checked with R 3.0.1 and 3.0.2
> > which I don't have installed).
>
> That doesn't necessarily mean that 3.0.0 was fine.  It's a segfault
(I'd
> guess some memory being accessed after being freed), and it comes and
> goes as I add debugging print statements --- so it might have been there
> in 3.0.0 but we just got lucky and it never surfaced.
>
> Still, it's a start, and I'll try bisecting between 3.0.0 and 3.0.3
to
> see if some change caused it, rather than just triggered it.
I've tracked this down, and I believe I have a working fix now.  The 
issue was that the bug fix for PR#14872, a similar problem on Linux, 
fixed Linux and introduced a new bug in Windows.  For future reference, 
the problem is that it is currently not safe to call error() in a 
Windows event handler.  We may try to fix that over the summer, the 
current fix just avoids doing it.

Duncan Murdoch