Hi! The attached patch changes the rule that describes the actions for gramLatex.c in src/library/tools/src/Makefile.in so it actually generates that file instead of "gramLatex." (no extension). The file name without extension is not referenced anywhere else and in R-2.12 the same rule still used the full name, so it appears that the "c" was lost in editing somewhere along the way. The patch was generated for R-3.0.1, but also applies cleanly to R-devel_2013-05-14. -ik -------------- next part -------------- A non-text attachment was scrubbed... Name: fix-gramLatex-name.patch Type: text/x-diff Size: 613 bytes Desc: not available URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20130516/318aa2c3/attachment.bin>
On 13-05-16 5:26 AM, Ingo Korb wrote:> Hi! > > The attached patch changes the rule that describes the actions for > gramLatex.c in src/library/tools/src/Makefile.in so it actually > generates that file instead of "gramLatex." (no extension). The > file name without extension is not referenced anywhere else and > in R-2.12 the same rule still used the full name, so it appears > that the "c" was lost in editing somewhere along the way. > > The patch was generated for R-3.0.1, but also applies cleanly to > R-devel_2013-05-14.Thanks, I'll put your fix in. Duncan Murdoch
Thanks. Yes, that certainly looks like a copy/paste error when the gram* files was moved to tools. (I just wonder why we're not using $< $@ in these rules.) It should be harmless until someone tries actually modifying the grammar. (To avoid relying on yacc/bison, we ship the gram*.c along with gram*.y). -pd On May 16, 2013, at 11:26 , Ingo Korb wrote:> Hi! > > The attached patch changes the rule that describes the actions for > gramLatex.c in src/library/tools/src/Makefile.in so it actually > generates that file instead of "gramLatex." (no extension). The > file name without extension is not referenced anywhere else and > in R-2.12 the same rule still used the full name, so it appears > that the "c" was lost in editing somewhere along the way. > > The patch was generated for R-3.0.1, but also applies cleanly to > R-devel_2013-05-14. > > -ik > <fix-gramLatex-name.patch>______________________________________________ > R-devel at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-devel-- Peter Dalgaard, Professor Center for Statistics, Copenhagen Business School Solbjerg Plads 3, 2000 Frederiksberg, Denmark Phone: (+45)38153501 Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com