R devel - Jun 2011 - Small bug in install.packages?

When capturing the path to the current R binary, install.packages does:

  cmd0 <- paste(file.path(R.home("bin"), "R"), "CMD
INSTALL")

shouldn't that be

  cmd0 <- shQuote(paste(file.path(R.home("bin"), "R"),
"CMD INSTALL"))

to allow paths with spaces in them (which would be very common on windows)?

Hadley


-- 
Assistant Professor / Dobelman Family Junior Chair
Department of Statistics / Rice University
http://had.co.nz/

On Jun 28, 2011, at 3:03 PM, Hadley Wickham wrote:
> When capturing the path to the current R binary, install.packages does:
> 
>  cmd0 <- paste(file.path(R.home("bin"), "R"),
"CMD INSTALL")
> 
> shouldn't that be
> 
>  cmd0 <- shQuote(paste(file.path(R.home("bin"),
"R"), "CMD INSTALL"))
> 
> to allow paths with spaces in them (which would be very common on windows)?
> 
Isn't R.home() 8.3 path anyway?

BTW: I think you probably meant more something like
paste(shQuote(file.path(R.home("bin"), "R")), "CMD
INSTALL") since the above won't work ..

Cheers,
S