R devel - Jun 2005 - dotcode typo?

I ran across the following in the R-2.0.1 source, src/main/dotcode.c, in the
function resolveNativeRoutine(), lines 146-163. Line 152 looks like a typo:
here are lines 149-155

 if(!*fun) {
        if(dll.type != FILENAME) {
            *fun = R_FindNativeSymbolFromDLL(buf, &dll, symbol);
            if(!fun) {
                errorcall(call, "cannot resolve native routine");
            }
        }

and I think the "if(!fun)" should be "if(!*fun)". 

Reid Huntsinger

Sorry, I was looking at 2.0.1 when I meant to be looking at 2.1.0. The line
numbers for the latter are 161-179 and line 164 is the one with what I think
is a typo.

Reid Huntsinger

-----Original Message-----
From: r-devel-bounces@stat.math.ethz.ch
[mailto:r-devel-bounces@stat.math.ethz.ch] On Behalf Of Huntsinger, Reid
Sent: Thursday, June 02, 2005 12:33 PM
To: r-devel@stat.math.ethz.ch
Subject: [Rd] dotcode typo?


I ran across the following in the R-2.0.1 source, src/main/dotcode.c, in the
function resolveNativeRoutine(), lines 146-163. Line 152 looks like a typo:
here are lines 149-155

 if(!*fun) {
        if(dll.type != FILENAME) {
            *fun = R_FindNativeSymbolFromDLL(buf, &dll, symbol);
            if(!fun) {
                errorcall(call, "cannot resolve native routine");
            }
        }

and I think the "if(!fun)" should be "if(!*fun)". 

Reid Huntsinger

______________________________________________
R-devel@stat.math.ethz.ch mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

----------------------------------------------------------------------------
--
Notice:  This e-mail message, together with any attachments,...{{dropped}}