R 2.1.0/src/include from 2005/04/18 download
Naming inconsistent for guards as well but that's pedantic.
Simple convention:
file <foo.h>
#ifndef R_FOO_H
file <R_ext/bar.h>
#ifndef R_EXT_BAR_H
Missing guards:
<IOStuff.h>
<Internal.h>
<Parse.h>
<R_ext/GraphicsBase.h>
<R_ext/GraphicsDevice.h>
<R_ext/GraphicsEngine.h>
<R_ext/R-ftp-http.h>
<R_ext/libextern.h>
Illegal Guards (leading underscore):
<Rinternals.h>
<R_ext/Error.h>
<config.h.in>
----------------------------------------------------------
SIGSIG -- signature too long (core dumped)
On Wed, 18 May 2005, Paul Roebuck wrote:> R 2.1.0/src/include from 2005/04/18 download > > Naming inconsistent for guards as well but that's pedantic. > Simple convention: > file <foo.h> > #ifndef R_FOO_H > file <R_ext/bar.h> > #ifndef R_EXT_BAR_H > > Missing guards: > <IOStuff.h> > <Internal.h> > <Parse.h> > <R_ext/GraphicsBase.h> > <R_ext/GraphicsDevice.h> > <R_ext/GraphicsEngine.h> > <R_ext/R-ftp-http.h> > <R_ext/libextern.h> > > > Illegal Guards (leading underscore): > <Rinternals.h> > <R_ext/Error.h> > <config.h.in>What is `illegal' about that? -- Brian D. Ripley, ripley@stats.ox.ac.uk Professor of Applied Statistics, http://www.stats.ox.ac.uk/~ripley/ University of Oxford, Tel: +44 1865 272861 (self) 1 South Parks Road, +44 1865 272866 (PA) Oxford OX1 3TG, UK Fax: +44 1865 272595
Paul Roebuck <roebuck@odin.mdacc.tmc.edu> writes:> R 2.1.0/src/include from 2005/04/18 download > > Naming inconsistent for guards as well but that's pedantic. > Simple convention: > file <foo.h> > #ifndef R_FOO_H > file <R_ext/bar.h> > #ifndef R_EXT_BAR_H > > Missing guards: > <IOStuff.h> > <Internal.h> > <Parse.h> > <R_ext/GraphicsBase.h> > <R_ext/GraphicsDevice.h> > <R_ext/GraphicsEngine.h> > <R_ext/R-ftp-http.h> > <R_ext/libextern.h> > > > Illegal Guards (leading underscore): > <Rinternals.h> > <R_ext/Error.h> > <config.h.in>Thanks. The ones outside R_ext, except Rinternals.h, are not part of the API, so it is not a bug that there are no guards - could still be a good idea to have them of course. libextern.h explicitly says that you shouldn't disallow including it more than once. So the ones with real problems would be <R_ext/GraphicsBase.h> <R_ext/GraphicsDevice.h> <R_ext/GraphicsEngine.h> <R_ext/R-ftp-http.h> <Rinternals.h> <R_ext/Error.h> What's illegal about leading underscores, BTW? -- O__ ---- Peter Dalgaard Blegdamsvej 3 c/ /'_ --- Dept. of Biostatistics 2200 Cph. N (*) \(*) -- University of Copenhagen Denmark Ph: (+45) 35327918 ~~~~~~~~~~ - (p.dalgaard@biostat.ku.dk) FAX: (+45) 35327907