On Thu, 12 Apr 2001, Prof Brian Ripley wrote:> On Thu, 12 Apr 2001 ligges@statistik.uni-dortmund.de wrote: > > > "Rcmd check" on NT does not catch errors generated by stop() in files > > in the tests directory. Thus the fact that all the tests complete does > > not mean they completed succesfully.In my experiments it *does* put out an error but continues. This is intentional, as some Perls are rather flaky. If you want to change it, remove the leading `-' in line 29 of etc/Makeconf-tests.> > This report is based on output from Rcmd check for the bundle dseplus > > version 2001.4-1. The test curve/tests/crvB07.R does a comparison which > > on NT is outside of tolerance and executes stop(). (The comparison value > > has been adjusted so that future versions of dseplus will not fail on > > this test.) > > Perl version? (Lots of these things depend critically on the build.) > Does make pkgcheck-foo work or not?That does work for me, with build 613 (and at least 619-621 are known to have broken system() calls). If you are not seeing an error on the console as the tests run, something else is up in your setup (not at all unlikely with Windows makes). On the other hand, Rcmd check dse fails for me because the scripts are asking for interactive input (the number of singular values) and chewing up the rest of the script. That *is* a bug in dse. In general, make pkgcheck-foo is more reliable under Windows. BTW, this has nothing whatsoever to do with Rcmd! -- Brian D. Ripley, ripley@stats.ox.ac.uk Professor of Applied Statistics, http://www.stats.ox.ac.uk/~ripley/ University of Oxford, Tel: +44 1865 272861 (self) 1 South Parks Road, +44 1865 272860 (secr) Oxford OX1 3TG, UK Fax: +44 1865 272595 -.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.- r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html Send "info", "help", or "[un]subscribe" (in the "body", not the subject !) To: r-devel-request@stat.math.ethz.ch _._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._
>> > "Rcmd check" on NT does not catch errors generated by stop() in files >> > in the tests directory. Thus the fact that all the tests complete does >> > not mean they completed succesfully.>In my experiments it *does* put out an error but continues. This is >intentional, as some Perls are rather flaky. If you want to change it, >remove the leading `-' in line 29 of etc/Makeconf-tests.Knowing little about Windows I won't try to suggest what the default should be for Windows. However, I do rely on make stopping when there is an error signalled by "R CMD build". There is too much output to examine manually every time I test a package. In general I think errors may go unnoticed for a long time if make does not stop on errors, so I think the idea of continuing is a bit risky. But perhaps I should be using something other than "R CMD build" to do testing. I thought things had recently changed so that this was the preferred way to test a package?>On the other hand, Rcmd check dse fails for me because the scripts >are asking for interactive input (the number of singular values) and >chewing up the rest of the script. That *is* a bug in dse.That is a bug in some examples, thanks for pointing it out. Is there a strategy for handling interactive input to examples? I don't seem to get the "chewing up the rest of the script" though. I also don't get any failure in the sense of an error signalled to R CMD build or to my make. For the reasons mentioned above I think that might be a good thing to do. Paul Gilbert -.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.- r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html Send "info", "help", or "[un]subscribe" (in the "body", not the subject !) To: r-devel-request@stat.math.ethz.ch _._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._
>>>>> "PaulG" == Paul Gilbert <pgilbert@bank-banque-canada.ca> writes:.......... >> On the other hand, Rcmd check dse fails for me because the scripts >> are asking for interactive input (the number of singular values) and >> chewing up the rest of the script. That *is* a bug in dse. PaulG> That is a bug in some examples, thanks for pointing it out. Is PaulG> there a strategy for handling interactive input to examples? As Brian said, they "not allowed at all" for normal (tested) part of the examples. If you want to *show* them in the example section of your help {*and* allow the ESS user to send them linewise (by "l") or regionwise} you must wrap these parts into \dontrun{ ... your interactive things ... } Note that this will be improved, once we move to a more general documentation format (based on xml). Martin -.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.-.- r-devel mailing list -- Read http://www.ci.tuwien.ac.at/~hornik/R/R-FAQ.html Send "info", "help", or "[un]subscribe" (in the "body", not the subject !) To: r-devel-request@stat.math.ethz.ch _._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._