Puppet users - Jul 2013 - Puppet code review - suggestions and options

We are looking to implement a code review system that will require a review 
of the code before it gets to production servers.  I have been looking into 
many different options, and would love some feedback and experiences from 
other users.  

Our puppet is in a git repo.  We have 3 primary environments with a branch 
of puppet for each of them.  All of our puppet info is in the git repo 
(it''s pretty big)  We stage our commits in local topic branches then
merge
these topic branches into the environments as necessary.  I imagine this is 
pretty standard.

I mention this basic workflow because after doing a quite a bit of 
research, I notice that when implementing code review, defining the 
workflow is probably the most important step. After this is defined, a 
system can be designed around it.

The go to git code review seems to be gerrit.  I would love to hear 
experiences from others that are specifically using gerrit with puppet for 
reviewing puppet code.  I''d really like to hear your workflow and how 
gerrit fits into it.  After instlaling a test environment, some of the 
questions arise:

Are you using gerrit''s jgit  as your puppetmaster git repo on the 
puppetmaster?

If not, how are you transferring the git repo from gerrit to the 
puppetmaster?

Are you using jenkins with gerrit?  

If so, what jobs do you have jenkins doing? 

If you are using jenkins with gerrit to do puppet lint/syntax checking, are 
you checking the entire puppet repo or just the changes that are committed?

Are you happy with the gerrit + puppet experience?


Also, if anyone else is doing code review with puppet to, what are you 
using?



-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users.
For more options, visit https://groups.google.com/groups/opt_out.

On 09.07.2013 17:32, Matt Woodson wrote:
> The go to git code review seems to be gerrit.  I would love to hear
> experiences from others that are specifically using gerrit with puppet
> for reviewing puppet code.  I''d really like to hear your workflow
and
> how gerrit fits into it.  After instlaling a test environment, some of
> the questions arise:
>
> Are you using gerrit''s jgit  as your puppetmaster git repo on the
> puppetmaster?
> If not, how are you transferring the git repo from gerrit to the
> puppetmaster?
The puppetmaster has a gerrit stream-events listener which updates the 
local checkouts (one per environment/branch) when changes are submitted.
> Are you using jenkins with gerrit?
> If so, what jobs do you have jenkins doing?
At one customer I just finished adding syntax checks for .pp (puppet 
parser validate) and erb checks via jenkins. the change cannot be 
submitted if the check fails. Currently jenkins even does 
auto-submitting when a change is green since the team is so small.

I plan to start using that everywhere. Next up will be running rspecs, 
although I do not expect much from them. Finally I''m thinking about 
vagranting up some VMs for more dynamic checks, but that''s pretty 
resource intense, so it''ll need more thought on what to actually check.
> If you are using jenkins with gerrit to do puppet lint/syntax checking,
> are you checking the entire puppet repo or just the changes that are
> committed?
Everything. It takes only a few seconds for the whole repo.
> Are you happy with the gerrit + puppet experience?
For the first steps it was great. It''ll be interesting to see how it 
works out in the long run and over a wider variety of shops.



Regards, David

-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users.
For more options, visit https://groups.google.com/groups/opt_out.