Puppet users - Mar 2013 - syntax checking nodes, don't allow global scope

Hi,

We have been bitten twice by the following.  We group the configuration 
or our nodes in several files.

nodes.d/group1.pp
nodes.d/group2.pp
...

Now twice people have accidently added some statements that are put in 
the global scope... which are then applied to all nodes:

The example is simplified:

-------nodes.d/group1.pp-----
node mynode {
   ...
}
include thisorthat
----------------


Ofcourse this doesn''t trigger a syntax error (that we run before a push
to the git repo can be done).

Are there any other ways to catch this?  Except code revision 

Thanks,

Rudy



-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Hi,

None that I know of - its the same as putting includes in site.pp. Education and
review are your best bet.

Den

(That said, very verbose rspec tests may pick it up for very specific cases -
but it would be a bit of work.)


On 12/03/2013, at 23:31, Rudy Gevaert <rudy.gevaert@gmail.com> wrote:
> Hi,
> 
> We have been bitten twice by the following.  We group the configuration 
> or our nodes in several files.
> 
> nodes.d/group1.pp
> nodes.d/group2.pp
> ...
> 
> Now twice people have accidently added some statements that are put in 
> the global scope... which are then applied to all nodes:
> 
> The example is simplified:
> 
> -------nodes.d/group1.pp-----
> node mynode {
>    ...
> }
> include thisorthat
> ----------------
> 
> 
> Ofcourse this doesn''t trigger a syntax error (that we run before a
push
> to the git repo can be done).
> 
> Are there any other ways to catch this?  Except code revision 
> 
> Thanks,
> 
> Rudy
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to puppet-users+unsubscribe@googlegroups.com.
> To post to this group, send email to puppet-users@googlegroups.com.
> Visit this group at http://groups.google.com/group/puppet-users?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
-- 
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscribe@googlegroups.com.
To post to this group, send email to puppet-users@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.