Puppet users - Aug 2009 - puppet & munin : little things added

Hi list,

On the advice of DavidS I send mail to the list to advertise about some
modifications/enhancements I''ve made to his munin classes.

The stuff is here : http://www.rottenbytes.info/?p=200 

It is also available through planetpuppet.org, but everyone already
reads it right ? ;)

Regards,

Nico.

Nicolas Szalay wrote:
> Hi list,
> 
> On the advice of DavidS I send mail to the list to advertise about some
> modifications/enhancements I''ve made to his munin classes.
> 
> The stuff is here : http://www.rottenbytes.info/?p=200 
Cool, thanks for publishing!

Some notes and questions:

   * In the munin::node, the case could be replaced with
       include "munin::node::${operatingsystem}"

   * The different munin::node::* classes have bits in common. Have you
     thought about moving some things into a common base class?

   * Service["cron"]: Managing this here will preset others with
     conflicts when they want to manage cron separately. Currently there
     is no good solution for this, but for starters I''d propose just
     include()ing a "service::cron" class, just to document the
     dependency.

   * You have the same "case $operatingsystem" block setting the
     script_path and plugins_dir. You can put that in the top-level scope
     or the munin::node and save yourself the headache of having to keep
     them in sync. Then you should rename them to munin_* and protect the
     whole "case" with "if ! defined(...)". That way this
can be
     overridden on a per-node basis if needed.

   * There are several files you reference but do not provide in the post
     (munin-graph, munin.cron, etc).

   * How does the muningen.rb script work?



If you''re interested and can provide me with patches, I''d be
more than
happy to integrate this into my repo.


Regards, DavidS

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com
To unsubscribe from this group, send email to
puppet-users+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Le mercredi 05 août 2009 à 10:48 +0200, David Schmitt a écrit
:
> Cool, thanks for publishing!
> 
> Some notes and questions:
> 
>    * In the munin::node, the case could be replaced with
>        include "munin::node::${operatingsystem}"
Did not think of this, thanks for the tip.
>    * The different munin::node::* classes have bits in common. Have you
>      thought about moving some things into a common base class?
which ones ? I just see the "service { "munin-node": ensure =>
running }". The include munin::plugins::* could be replaced by
munin::plugins::${operatingsystem} as you just specified
>    * Service["cron"]: Managing this here will preset others with
>      conflicts when they want to manage cron separately. Currently there
>      is no good solution for this, but for starters I''d propose
just
>      include()ing a "service::cron" class, just to document the
>      dependency.
Hum, I had not though to this, probably because I don''t manage cron
service through puppet (yet)
>    * You have the same "case $operatingsystem" block setting the
>      script_path and plugins_dir. You can put that in the top-level scope
>      or the munin::node and save yourself the headache of having to keep
>      them in sync. Then you should rename them to munin_* and protect the
>      whole "case" with "if ! defined(...)". That way
this can be
>      overridden on a per-node basis if needed.
Yes, finished this part late and my mind was not very clear :)
>    * There are several files you reference but do not provide in the post
>      (munin-graph, munin.cron, etc).
Yes, see attached files.
* munin-cron => modified debian crontab file. Month & Year generation
are just done once a day. Sufficient for me
* munin-graph => enables parralel graph generation to speed up things.
(wrote some bits in french about this here =>
http://www.rottenbytes.info/?p=63)
>    * How does the muningen.rb script work?
It just extracts some data from my CMDB corresponding to generate the
munin.conf file. It''s mostly an SQL request that extracts hostname, IP,
and munin group. Nothing fancy.
> If you''re interested and can provide me with patches, I''d
be more than
> happy to integrate this into my repo.
Will have to fix the points above before then :)

Thanks for the feedback,

Nico.