Hi all, I''ve just merged in support for builtin Nagios types into the 0.24.x branch, and I''d like people to give them a once-over before I incorporate them into a release (based on a few (hopefully small) outstanding bugs in 0.24.1, I expect I''ll put out a 0.24.2 in the next week or so). The only thing I''d currently consider a gotcha right now is that the default target is /etc/nagios/nagios_<name>.cfg. It''s basically trivial to change this, but I had to start somewhere. If you look in lib/puppet/type/nagios*, you''ll see basically one-line files, since each of the types is just generated using the model I created in my Naginator[1] library. Can anyone think of anything I should specifically do better or differently? Thanks. 1 - http://reductivelabs.com/trac/naginator -- The only difference between the Democrats and the Republicans is that the Democrats allow the poor to be corrupt, too. -- Oscar Levant --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com
Luke Kanies schrieb:> Hi all, > > I''ve just merged in support for builtin Nagios types into the 0.24.x > branch, and I''d like people to give them a once-over before I > incorporate them into a release (based on a few (hopefully small) > outstanding bugs in 0.24.1, I expect I''ll put out a 0.24.2 in the > next week or so). > > The only thing I''d currently consider a gotcha right now is that the > default target is /etc/nagios/nagios_<name>.cfg. It''s basically > trivial to change this, but I had to start somewhere.The FHS would recommend somewhere under /var for generated content, so $statedir/nagios/ might be a good idea. My modules all put their stuff into $vardir/modules/$modulename/.> If you look in lib/puppet/type/nagios*, you''ll see basically one-line > files, since each of the types is just generated using the model I > created in my Naginator[1] library. > > Can anyone think of anything I should specifically do better or > differently?I''m really sorry that I cannot currently create some free time to look at the code. I can only point you at my nagios module at http://git.black.co.at/?p=module-nagios, but I guess you know that one already. Regards, David
On Jan 2, 2008, at 5:12 AM, David Schmitt wrote:> Luke Kanies schrieb: >> Hi all, >> >> I''ve just merged in support for builtin Nagios types into the 0.24.x >> branch, and I''d like people to give them a once-over before I >> incorporate them into a release (based on a few (hopefully small) >> outstanding bugs in 0.24.1, I expect I''ll put out a 0.24.2 in the >> next week or so). >> >> The only thing I''d currently consider a gotcha right now is that the >> default target is /etc/nagios/nagios_<name>.cfg. It''s basically >> trivial to change this, but I had to start somewhere. > > The FHS would recommend somewhere under /var for generated content, so > $statedir/nagios/ might be a good idea. My modules all put their stuff > into $vardir/modules/$modulename/.Unfortunately these files seem to be subject to two standards: They''re configuration files (thus, /etc) and generated (thus, /var). I tried to pick what I expected Nagios would look for by default -- my goal was to keep users from having to reconfigure their Nagios systems to use this. Maybe that''s silly, though.>> If you look in lib/puppet/type/nagios*, you''ll see basically one-line >> files, since each of the types is just generated using the model I >> created in my Naginator[1] library. >> >> Can anyone think of anything I should specifically do better or >> differently? > > > I''m really sorry that I cannot currently create some free time to look > at the code. I can only point you at my nagios module at > http://git.black.co.at/?p=module-nagios, but I guess you know that one > already.Yep, I looked at it. Your modules are mostly focused on managing Nagios, rather than managing its configuration files, so there didn''t seem to be much to glean. -- Commit suicide. A hundred thousand lemmings can''t be wrong. --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com
Luke Kanies schrieb:> On Jan 2, 2008, at 5:12 AM, David Schmitt wrote: > >> Luke Kanies schrieb: >>> Hi all, >>> >>> I''ve just merged in support for builtin Nagios types into the 0.24.x >>> branch, and I''d like people to give them a once-over before I >>> incorporate them into a release (based on a few (hopefully small) >>> outstanding bugs in 0.24.1, I expect I''ll put out a 0.24.2 in the >>> next week or so). >>> >>> The only thing I''d currently consider a gotcha right now is that the >>> default target is /etc/nagios/nagios_<name>.cfg. It''s basically >>> trivial to change this, but I had to start somewhere. >> The FHS would recommend somewhere under /var for generated content, so >> $statedir/nagios/ might be a good idea. My modules all put their stuff >> into $vardir/modules/$modulename/. > > Unfortunately these files seem to be subject to two standards: > They''re configuration files (thus, /etc) and generated (thus, /var). > > I tried to pick what I expected Nagios would look for by default -- > my goal was to keep users from having to reconfigure their Nagios > systems to use this. Maybe that''s silly, though.Yeah that''s a good point. In the end I think it really comes down to "does anybody still manually change anything on the node?" If no, most of FHS is moot anyways.>>> If you look in lib/puppet/type/nagios*, you''ll see basically one-line >>> files, since each of the types is just generated using the model I >>> created in my Naginator[1] library. >>> >>> Can anyone think of anything I should specifically do better or >>> differently? >> >> I''m really sorry that I cannot currently create some free time to look >> at the code. I can only point you at my nagios module at >> http://git.black.co.at/?p=module-nagios, but I guess you know that one >> already. > > Yep, I looked at it. Your modules are mostly focused on managing > Nagios, rather than managing its configuration files, so there didn''t > seem to be much to glean.I do have nagios::command, nagios::service and nagios::host defines for the respective nagios objects. Not complete, but that was everything I needed. Regards, DavidS