Pkg xen devel - Mar 2016 - Bug#818525: xen: FTBFS: error: unterminated comment

Package: xen
Version: 4.6.0-1+nmu2
Severity: serious

This package fails to build in unstable:
> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
...
> mkdir -p compat
> grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' public/grant_table.h | \
> python
/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/tools/compat-build-source.py
>compat/grant_table.c.new
> mv -f compat/grant_table.c.new compat/grant_table.c
> gcc -E -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -DNDEBUG
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-generic
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs
-DHAVE_GAS_VMX -DHAVE_GAS_EPT -DHAVE_GAS_FSGSBASE -mno-red-zone -mno-sse -fpic
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
-fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g -D__XEN__
-nostdinc -DCONFIG_SHADOW_PAGING -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH
-DHAS_MEM_ACCESS -DHAS_MEM_PAGING -DHAS_MEM_SHARING -DHAS_PCI -DHAS_IOPORTS
-DHAS_PDX -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prot
> otypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -include public/xen-compat.h -m32 -o
compat/grant_table.i compat/grant_table.c
> compat/grant_table.c:33:1: error: unterminated comment
>  /*
>  ^
> compat/grant_table.c:28:0: error: unterminated #ifndef
>  #ifndef __XEN_PUBLIC_GRANT_TABLE_H__
>  ^
> Makefile:61: recipe for target 'compat/grant_table.i' failed
> make[5]: *** [compat/grant_table.i] Error 1
> rm compat/features.i compat/callback.c compat/event_channel.i
compat/elfnote.c compat/elfnote.i compat/features.c compat/event_channel.c
compat/callback.i compat/grant_table.c
-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise

On Thu, Mar 17, 2016 at 6:58 PM, Martin Michlmayr <tbm at hpe.com>
wrote:
> Package: xen
> Version: 4.6.0-1+nmu2
> Severity: serious
>
> This package fails to build in unstable:
>
>> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
> ...
>> mkdir -p compat
>> grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' public/grant_table.h |
\
>> python
/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/tools/compat-build-source.py
>compat/grant_table.c.new
>> mv -f compat/grant_table.c.new compat/grant_table.c
>> gcc -E -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs -DNDEBUG
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-generic
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs
-DHAVE_GAS_VMX -DHAVE_GAS_EPT -DHAVE_GAS_FSGSBASE -mno-red-zone -mno-sse -fpic
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
-fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g -D__XEN__
-nostdinc -DCONFIG_SHADOW_PAGING -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH
-DHAS_MEM_ACCESS -DHAS_MEM_PAGING -DHAS_MEM_SHARING -DHAS_PCI -DHAS_IOPORTS
-DHAS_PDX -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prot
>> otypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -include public/xen-compat.h -m32 -o
compat/grant_table.i compat/grant_table.c
>> compat/grant_table.c:33:1: error: unterminated comment
>>  /*
>>  ^
>> compat/grant_table.c:28:0: error: unterminated #ifndef
>>  #ifndef __XEN_PUBLIC_GRANT_TABLE_H__
>>  ^
>> Makefile:61: recipe for target 'compat/grant_table.i' failed
>> make[5]: *** [compat/grant_table.i] Error 1
>> rm compat/features.i compat/callback.c compat/event_channel.i
compat/elfnote.c compat/elfnote.i compat/features.c compat/event_channel.c
compat/callback.i compat/grant_table.c
>
I think you need this patch from upstream xen.git.

commit 3f293c7caaefc2c37b61e44e8ebd5a7f1c554afb
Author:     Dario Faggioli <dario.faggioli at citrix.com>
AuthorDate: Thu Feb 25 13:03:04 2016 +0100
Commit:     Jan Beulich <jbeulich at suse.com>
CommitDate: Thu Feb 25 13:03:04 2016 +0100

    public: typo: use ' as apostrophe in grant_table.h


Wei.

> --
> Martin Michlmayr
> Linux for HPE Helion, Hewlett Packard Enterprise
>
> _______________________________________________
> Pkg-xen-devel mailing list
> Pkg-xen-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xen-devel

On 17.03.2016 22:10, Wei Liu wrote:
> On Thu, Mar 17, 2016 at 6:58 PM, Martin Michlmayr <tbm at hpe.com>
wrote:
>> Package: xen
>> Version: 4.6.0-1+nmu2
>> Severity: serious
>>
>> This package fails to build in unstable:
>>
>>> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
>> ...
>>> mkdir -p compat
>>> grep -v 'DEFINE_XEN_GUEST_HANDLE(long)'
public/grant_table.h | \
>>> python
/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/tools/compat-build-source.py
>compat/grant_table.c.new
>>> mv -f compat/grant_table.c.new compat/grant_table.c
>>> gcc -E -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing
-std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs -DNDEBUG
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-generic
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs
-DHAVE_GAS_VMX -DHAVE_GAS_EPT -DHAVE_GAS_FSGSBASE -mno-red-zone -mno-sse -fpic
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
-fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g -D__XEN__
-nostdinc -DCONFIG_SHADOW_PAGING -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH
-DHAS_MEM_ACCESS -DHAS_MEM_PAGING -DHAS_MEM_SHARING -DHAS_PCI -DHAS_IOPORTS
-DHAS_PDX -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-!
>  prot
>>> otypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs -include public/xen-compat.h -m32 -o
compat/grant_table.i compat/grant_table.c
>>> compat/grant_table.c:33:1: error: unterminated comment
>>>  /*
>>>  ^
>>> compat/grant_table.c:28:0: error: unterminated #ifndef
>>>  #ifndef __XEN_PUBLIC_GRANT_TABLE_H__
>>>  ^
>>> Makefile:61: recipe for target 'compat/grant_table.i'
failed
>>> make[5]: *** [compat/grant_table.i] Error 1
>>> rm compat/features.i compat/callback.c compat/event_channel.i
compat/elfnote.c compat/elfnote.i compat/features.c compat/event_channel.c
compat/callback.i compat/grant_table.c
>>
> 
> I think you need this patch from upstream xen.git.
That or change grep calls to add --text or change build calls to have
LANG=C.UTF-8 set. Unfortunately a not well (imo) designed behaviour of grep to
suddenly switch into "this is a binary file" mode without returning an
error code.

-Stefan
> 
> commit 3f293c7caaefc2c37b61e44e8ebd5a7f1c554afb
> Author:     Dario Faggioli <dario.faggioli at citrix.com>
> AuthorDate: Thu Feb 25 13:03:04 2016 +0100
> Commit:     Jan Beulich <jbeulich at suse.com>
> CommitDate: Thu Feb 25 13:03:04 2016 +0100
> 
>     public: typo: use ' as apostrophe in grant_table.h
> 
> 
> Wei.
> 
> 
>> --
>> Martin Michlmayr
>> Linux for HPE Helion, Hewlett Packard Enterprise
>>
>> _______________________________________________
>> Pkg-xen-devel mailing list
>> Pkg-xen-devel at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xen-devel
> 
> _______________________________________________
> Pkg-xen-devel mailing list
> Pkg-xen-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xen-devel
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20160318/73b9d8ed/attachment-0001.sig>

Your message dated Tue, 15 Nov 2016 15:38:28 +0000
with message-id <22571.11252.131395.33666 at mariner.uk.xensource.com>
and subject line Fixed by new upstream version
has caused the Debian Bug report #818525,
regarding xen: FTBFS: error: unterminated comment
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
818525: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818525
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS: error: unterminated comment
Date: Thu, 17 Mar 2016 11:58:24 -0700
Size: 4202
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161115/fd4bde9f/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ian.jackson at eu.citrix.com>
Subject: Fixed by new upstream version
Date: Tue, 15 Nov 2016 15:38:28 +0000
Size: 1693
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161115/fd4bde9f/attachment-0001.mht>

Your message dated Thu, 22 Dec 2016 18:49:44 +0000
with message-id <E1cK8Qy-0003ne-Hk at fasolo.debian.org>
and subject line Bug#818525: fixed in xen 4.8.0-1
has caused the Debian Bug report #818525,
regarding xen: FTBFS: error: unterminated comment
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
818525: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818525
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS: error: unterminated comment
Date: Thu, 17 Mar 2016 11:58:24 -0700
Size: 4202
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/9df69b72/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ian.jackson at eu.citrix.com>
Subject: Bug#818525: fixed in xen 4.8.0-1
Date: Thu, 22 Dec 2016 18:49:44 +0000
Size: 11301
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/9df69b72/attachment-0001.mht>